PDF Thumbnails in Media Library Don't Fall Back to Full Size

[daleharrison]

When previewing uploaded files in the Media Library, image thumbnails fall back to displaying the full size image when the option medium_size_h is set to 0 (the 0 setting is used to stop WordPress generating thumbs at that size).

The same functionality does not work for uploaded PDFs, instead displaying wp-includes/images/media/document.png in their place. The full-size thumbnail is generated, but not used.

The Attachment Details modal window successfully falls back to the full size image when previewing a PDF under the same circumstances.

[daleharrison]

Example of PDF Thumbnail Compared to Image Thumbnails in Media Library

[antpb]

This was discussed in a recent Media component meeting and we suspect that the fallback just needs one more step between medium and default pdf icon to include the full thumb after no medium found.

[mukesh27]

This ticket was discussed during the recent bug scrub. It looks like it's unlikely that work will be done on this during the 6.2 cycle.

@antpb Is this still possible to land in 6.2, or should it be moved to Future Release for now?

[joedolson]

Moving this to 6.3; @antpb hasn't had the time to tackle it during this cycle, but we still think this should be fixed soon.

[oglekler]

This ticket was discussed during bug scrub and due to lack of patch it was decided to move it out of the current 6.3 milestone. Seeing that @antpb wrote that working on it, I am moving this to 6.4.

Ad props to @mukesh27

[nicolefurlan]

Noting here that @antpb confirmed a few weeks ago that this would be addressed for 6.4. We're ~2 weeks from RC1 so just let us know if that is unlikely to happen by then.

[antpb]

I'm still pending a patch on this one and need to move to 6.5

[kushang78]

Added patch for this ticket.

[kushang78]

Successfully included the full thumb after no medium found. Please check the attached patch file.

Thanks!

[swissspidy]

@antpb Just checking in, is this still on your radar for 6.5?

[mai21]

@daleharrison Thanks for reporting the issue.

Just confirming the problem, is it in displaying pdf/audio file name here /wp-admin/upload.php?mode=grid?

[mai21]

pdf in media library

[daleharrison]

@mai21 Correct, I observed this in the grid view

[sudipatel007]

Test Report

---

Description

Patch has been tested and it is working as expected.
Now PDF Thumbnails is appeared in Media Library.

Environment

• WordPress: 6.6-beta3-58440-src
• PHP: 8.1.23
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
• Browser: Chrome 126.0.0.0 (macOS)
• Theme: Twenty Nineteen 2.8

Test Results

Now PDF Thumbnails is appeared in Media Library.

Screenshot - ​https://prnt.sc/Gw-lwpKt_tv8

[audrasjb]

As per today's bug scrub, we're going to move this ticket to 6.7. It's pretty close to resolution but we're also close to 6.6 RC1 and it wasn't committed yet.

[antpb]

In 58947:

Media: Implement fallback to full-size thumbnails for PDFs in Media Library.

When medium-size thumbnails are disabled, PDF previews in the Media Library grid view now fall back to displaying full-size thumbnails instead of a generic document icon.

Props daleharrison, kushang78, mukesh27, sudipatel007, mai21, antpb.
Fixes #39630.