![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 9 years ago
#39649 closed enhancement (wontfix)
$doaction variable doesn't follow the naming conventions in edit-comments.php:98
| Reported by: | xayer | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Comments | Version: | 4.7 |
| Severity: | normal | Keywords: | close |
| Cc: | Focuses: |
Description
Hi, on line edit-comments.php:98 (https://core.trac.wordpress.org/browser/tags/4.7/src/wp-admin/edit-comments.php#L98), there's a variable that doesn't follow the guidelines. According to the Naming Conventions (https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#naming-conventions) it should be $do_action.
<?php $redirect_to = apply_filters( 'handle_bulk_actions-' . get_current_screen()->id, $redirect_to, $do_action, $comment_ids ); ?>
Even the documentation doesn't follow the guidelines on:
https://developer.wordpress.org/reference/hooks/handle_bulk_actions-get_current_screen-id/()
Change History (2)
Note:
See TracTickets
for help on using tickets.
Unfortunately
$doactionis a global that has been used for many years, long before there were any guidelines or naming conventions. Renaming it is out of the question (break back-compat).