Missing singular placeholder, needed for some languages on comments.php

[bplv]

On comments.php of most of the bundled themes the singular form of the string is not available.

[bplv]

I have found this via code sniffer which shows this report

Line: 31 ERROR Missing singular placeholder, needed for some languages.

See ​https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

According to codex this is the proper placeholder,

<?php
printf( esc_html( _n( 'We deleted %d spam message.', 'We deleted %d spam messages.', $count, 'my-text-domain'  ) ), $count );

Which is not the case in most of the bundled themes.

[SergeyBiryukov]

Hi @bplv, welcome to Trac! Thanks for the ticket.

This is fixed in ​Twenty Sixteen and Twenty Seventeen, I guess we could update older themes to use proper plural forms here as well.

[bplv]

Hello, @SergeyBiryukov

I have added the patch.

Thank you.

[SergeyBiryukov]

@bplv: Looks good, thank you :)

[jbpaul17]

Punting to 4.8.1 per today's bug scrub.

[kakshak]

Hello @SergeyBiryukov,

I have merge 39660.diff to this version and it's working fine in my local environment.

[SergeyBiryukov]

Replying to SergeyBiryukov:

This is fixed in ​Twenty Sixteen and Twenty Seventeen

Just noticed get_comments_number() returns a string, and Twenty Sixteen compares it to an integer, which doesn't work as expected. Twenty Seventeen does it correctly.

[xkon]

Updates to TwentySixteen

[xkon]

Updated the patch to .2 to address this as well. Tested also all the themes again and it seems fine here.

Replying to SergeyBiryukov:

Just noticed get_comments_number() returns a string, and Twenty Sixteen compares it to an integer, which doesn't work as expected. Twenty Seventeen does it correctly.

[SergeyBiryukov]

In 41729:

Twenty Sixteen: Make sure comment number comparison in comments.php works as expected.

get_comments_number() returns a numeric string, not an integer.

See #39660.

[SergeyBiryukov]

In 41761:

Twenty Fifteen: Add missing singular placeholder in comments.php.

Uses the recommended pattern for better compatibility with languages that use the singular form for other numbers. Also adds translator comments.

Props bplv, xkon.
See #39660.

[SergeyBiryukov]

In 41762:

Twenty Fourteen: Add missing singular placeholder in comments.php.

Uses the recommended pattern for better compatibility with languages that use the singular form for other numbers. Also adds translator comments.

Props bplv, xkon.
See #39660.

[SergeyBiryukov]

Twenty Fourteen, Fifteen, Sixteen, and Seventeen use the recommended pattern now.

I guess Twenty Thirteen and older themes should be left as is, as they are used with WP versions that don't support language packs, so updating translations is not a trivial task there.

[ismail.elkorchi]

@SergeyBiryukov I think that, instead of converting 1 to '1', it is best to do the opposite by converting get_comments_number() to an integer using intval().

See: ​http://php.net/manual/en/function.intval.php