WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#39661 closed defect (bug) (wontfix)

Twenty Twelve theme uses title tag instead of add_theme_support( 'title-tag' )

Reported by: bplv Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7.1
Component: Bundled Theme Keywords:
Focuses: Cc:
PR Number:

Description

Use of title tag is highly discouraged on a theme.

We can find this statement in theme review guideline

Avoid hard coding to modify content. Instead, use function parameters, filters and action hooks where appropriate. For example wp_title should be modified using a filter.

This is a must meet requirement for a theme according to theme review guidelines.

Change History (2)

#1 @SergeyBiryukov
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Summary changed from TwentyTwelve theme uses title tag instead of add_theme_support( 'title-tag' ) to Twenty Twelve theme uses title tag instead of add_theme_support( 'title-tag' )

Hi @bplv, welcome to Trac! Thanks for the ticket.

It's not just Twenty Twelve, most of the older themes (Twenty Ten to Twenty Fourteen) do the same. In #34456, it was decided not to update them to avoid breaking backwards compatibility.

Newer themes (Twenty Fifteen to Twenty Seventeen) use add_theme_support( 'title-tag' ).

#2 @bplv
3 years ago

@SergeyBiryukov oh okay, did not know about that.

Sorry and thank you for the info :)

Note: See TracTickets for help on using tickets.