WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 3 months ago

#39675 closed enhancement (fixed)

Remove unnecessary admin notification about deprecated `WPLANG`

Reported by: flixos90 Owned by: desrosj
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch dev-feedback commit
Focuses: administration Cc:

Description

In wp-admin/options-general.php a notification is shown to admins if the deprecated WPLANG constant is defined. @ocean90 brought up the possibility of removing this check while discussing #39207.

In my opinion the admin notice can be removed, since a regular _deprecated_argument() notice is already thrown for developers. While we generally expect the admin to do some tweaks to wp-config.php in a few areas, I think this notice is something that could easily confuse non-technical users.

Attachments (1)

39675.diff (916 bytes) - added by iworks 4 months ago.

Download all attachments as: .zip

Change History (6)

#1 @swissspidy
4 months ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.2

@iworks
4 months ago

#2 @swissspidy
4 months ago

  • Keywords has-patch added; needs-patch removed

#3 @swissspidy
4 months ago

  • Type changed from defect (bug) to enhancement

#4 @desrosj
3 months ago

  • Keywords dev-feedback commit added
  • Owner set to desrosj
  • Status changed from new to reviewing

Spoke with @ocean90 and @swissspidy on Slack. Both felt this was good to go.

#5 @desrosj
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44946:

I18N: Remove admin notice when the WPLANG constant is no longer necessary.

Introduced in [29630], this admin notice informs administrators (or network administrators on multisite installs) that the WPLANG constant is no longer needed when the locale returned by get_locale() does not match. After 5 years, the notice is being removed to avoid causing confusion for non-technical users.

The _deprecated_argument() call will persist to inform developers of the issue within log files.

Props flixos90, iworks, ocean90.
Fixes #39675.

Note: See TracTickets for help on using tickets.