Opened 8 years ago
Closed 4 years ago
#39685 closed defect (bug) (fixed)
Twenty Seventeen: Pagination links don't appear for home pages
Reported by: | dimitris.m | Owned by: | ianbelanger |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 4.7.1 |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch |
Focuses: | ui | Cc: |
Description
Steps to reproduce:
- Create a new page and split its content with <!--nextpage-->
- Set this page to be your Home one (under Settings/Reading)
- Visit the page in the front-end
The Pagination links aren't shown at all in the bottom of the page.
This works if the page isn't set for Home and also works with the "TwentySixteen" theme.
Attachments (8)
Change History (18)
#1
@
8 years ago
- Component changed from Themes to Bundled Theme
- Summary changed from Pagination links don't appear for home Pages in "TwentySeventeen" to Twenty Seventeen: Pagination links don't appear for home pages
@
6 years ago
Twenty Seventeen - both the front page and about page content appearing on the front page
#2
@
6 years ago
- Keywords needs-patch has-screenshots added
- Milestone changed from Awaiting Review to Future Release
Thanks for reporting this, @dimitris.m!
I can recreate this as well, both by trying to add a page break to the front page's content, and trying to add a page break to one of the pages showing on the front page.
This happens with both the classic and block-based editor.
#4
@
5 years ago
- Keywords needs-testing dev-feedback added
I updated the patch so that pagination will work on the homepage and in the homepage panels. Would love to get some feedback from other devs on this one.
#6
@
5 years ago
Looking at themes TwentyNineteen and TwentyTwenty, this is exactly how they handle this, so I don’t see any issues with this patch.
I can also confirm that @poena’s patch fixed the home page and @ianbelanger’s patch improved on this to add the fix to the Front Page Sections (these are the sections used in Customise->Theme Options).
Something interesting I noticed was that, if you have 2 pages on the home page and go to the 2nd page of the homepage, the other pages listed on the home screen will also go to the 2nd page.
For example, I have the "home" page as the WordPress Home page and the "sample page" as the Front page section 1, if I click on page 2 of the page called "home", the "sample page" will go to the 2nd page also (because every page on the homepage will go to page 2). I'm not sure how likely this will be, or what can be done about this, but I thought I'd mention it anyway... I'll add screenshots for clarity.
#7
@
4 years ago
- Keywords commit added; needs-testing dev-feedback removed
- Owner set to ianbelanger
- Status changed from new to reviewing
Reviewing for commit.
Twenty Seventeen - front page editor