WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39692, comment 45


Ignore:
Timestamp:
08/07/2017 09:15:44 PM (10 months ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39692, comment 45

    initial v1  
    11@obenland I'm creating a suite of child themes for testing and debugging to confirm that the theme switching is resulting in nav menus being assigned to the new locations as expected: https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-permutations
    22
    3 Right now there is one test for a theme that has nav menu locations (primary, secondary) and another theme that has nav menu locations (top, footer) and it checks to confirm that the menus assigned to locations in the former theme get re-assigned to the locations in the latter theme. So far, so good! ✅ The tests pass: [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-permutations/blob/master/tests/nav_menus_switch_from_nav-menus-primary-secondary_to_nav-menus-top-footer.sh nav_menus_switch_from_nav-menus-primary-secondary_to_nav-menus-top-footer.sh]
     3Right now there is one test for a theme that has nav menu locations (primary, secondary) and another theme that has nav menu locations (top, footer) and it checks to confirm that the menus assigned to locations in the former theme get re-assigned to the locations in the latter theme. So far, so good! ✅ The [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-permutations/blob/master/tests tests] pass.
    44
    55These tests are a level above the unit tests in [attachment:39692.3.diff] (which are still needed) and more in the realm of acceptance testing, which is really going to be the only feasible way to test menu switching in the Customizer.