WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #39693, comment 88


Ignore:
Timestamp:
09/06/17 17:16:23 (5 months ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39693, comment 88

    v1 v2  
    77Some outstanding things that I see that need to be addressed: 
    88 
    9 * The lost widgets logic appears to be blowing a way old single widgets that lack widget numbers. I think [https://github.com/xwp/wordpress-develop/pull/251/files/https://github.com/xwp/wordpress-develop/blob/206f97d434748ea4b113cf91446f1efc70d44b83/src/wp-includes/widgets.php#L1152-L1158 that logic] could probably be removed? 
     9* The lost widgets logic appears to be blowing a way old single widgets that lack widget numbers. I think [https://github.com/xwp/wordpress-develop/blob/206f97d434748ea4b113cf91446f1efc70d44b83/src/wp-includes/widgets.php#L1152-L1158 that logic] could probably be removed? 
    1010* I was working on [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-permutations/blob/master/tests/widget-sidebars/scenarios.json scenarios] for testing the various sidebar [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-permutations theme permutations], and I found a [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-permutations/blob/c1f2074d060167f43e8eaa880a8e32859a00764a/tests/widget-sidebars/scenarios.json#L36-L45 scenario] where from a theme with 3 populated sidebars to a theme with 2 sidebars and then switching back to the theme with 3 sidebars results in the one sidebar that was not initially mapped being ''empty'' after having switched back. This seems bad to me. I think this is part of the orphaned sidebar question. 
    1111