Changes between Initial Version and Version 1 of Ticket #39696, comment 14
- Timestamp:
- 01/28/2017 02:02:27 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #39696, comment 14
initial v1 3 3 @adamsilverstein writing the unit tests to test `_embed` is proving to be difficult because of the use of $_GET. I don't see anywhere in the unit tests where any testing for `_embed` is done at all. As I started writing some unit tests I realised that there may actually be some logical issue with class-wp-rest-server.php itself. This would not be an issue if the $request object from `::serve_request()` were to either be 1) set to an object property or 2) passed to `::response_to_data()` (and subsequently passed to `::embed_links`). The `_embed` variable can then be pulled from $request->get_query_params() and we can thus avoid using $_GET altogether. 4 4 5 Some direction here would be appreciated :)5 Some direction here would be appreciated before I send my next patch :) 6 6