Changes between Initial Version and Version 1 of Ticket #39696, comment 17
- Timestamp:
- 01/29/2017 06:40:55 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #39696, comment 17
initial v1 2 2 > In any case I'll take a closer look this coming week. 3 3 4 No problem. I'm happy to make whichever changes you require me to make. The patch for the server works, but obviously the unit test had to be hacky as there were no tests before and the use rof $_GET probably has not been carefully considered. If you prefer I go with the option to pass the $request down the line to where its needed I am happy to do so... would make for a much cleaner unit test.4 No problem. I'm happy to make whichever changes you require me to make. The patch for the server works, but obviously the unit test had to be hacky as there were no tests before and the use of $_GET probably has not been carefully considered. If you prefer I go with the option to pass the $request down the line to where its needed I am happy to do so... would make for a much cleaner unit test. 5 5 6 6 Looking forward to hearing back from you.