wp-signup.php & wp-activate.php are doing an avoidable posts query

[imath]

Hi,

If in the reading settings of the site, i chose to list my latest posts as the home page: going on wp-signup.php or wp-activate.php will query & fetch the 10 latests posts for nothing in a way. Moreover In this case is_home() is true which is a bit confusing.

If in the reading settings of the site, i chose a static front page as the home page, it will be requested and fetched when going on wp-signup.php or wp-activate.php. In this case is_page() is true which is less confusing.

So i guess, the particularity of these two specific pages is they're getting the header and the footer of the active theme.

But i wonder why running wp() ?

By simply directly loading the wp-includes/template-loader.php it can save a query.

see signup-activate-1.patch

If running wp() is required for a reason i don't see, a query could still be saved and it could be interested to use this to set a "page" title for the <title> tag.

see signup-activate-2.patch

[johnjamesjacoby]

This is interesting. Good find.

I can't think of a problem with this, other than someone doing something weird that would still require the $wp_did_header check.

[sabernhardt]

I refreshed the patches for both options. I like having a special title for each page (option 2).

[oglekler]

This ticket was discussed during bug scrub.

Due to impact on the WP_Query class, it was decided to make it an early ticket plus this is a performance enhancement and not a bug, so, I am adjusting status, keywords and type.

Add props to @hellofromTonya

[rajinsharwar]

Well, if we just simply require the template-loader.php, instead of wp-blog-header.php, it solves the issue of those unnecessary queries. But, I am afraid this will break some plugin functionalities, for example in this case Query Monitor. The Query Monitor's debug bar doesn't show there if we do not call the wp() function.

I want to propose a different approach. Why don't we modify the parse_request() method or the main() method in WP class to not run any WP QUERY in the query args is empty?

[mukesh27]

Hi there!

Upon first review, it seems this needs next steps for path forward. I will move it to a future release for now. If anyone feels comfortable, we can move it back to the milestone.