Opened 7 years ago
Last modified 17 months ago
#39703 new defect (bug)
wp-signup.php & wp-activate.php are doing an avoidable posts query
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Login and Registration | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Description
Hi,
If in the reading settings of the site, i chose to list my latest posts as the home page: going on wp-signup.php
or wp-activate.php
will query & fetch the 10 latests posts for nothing in a way. Moreover In this case is_home()
is true which is a bit confusing.
If in the reading settings of the site, i chose a static front page as the home page, it will be requested and fetched when going on wp-signup.php
or wp-activate.php
. In this case is_page()
is true which is less confusing.
So i guess, the particularity of these two specific pages is they're getting the header and the footer of the active theme.
But i wonder why running wp()
?
By simply directly loading the wp-includes/template-loader.php
it can save a query.
see signup-activate-1.patch
If running wp()
is required for a reason i don't see, a query could still be saved and it could be interested to use this to set a "page" title for the <title>
tag.
see signup-activate-2.patch
This is interesting. Good find.
I can't think of a problem with this, other than someone doing something weird that would still require the
$wp_did_header
check.