Make WordPress Core

Opened 7 years ago

Last modified 3 months ago

#39703 new defect (bug)

wp-signup.php & wp-activate.php are doing an avoidable posts query

Reported by: imath's profile imath Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch needs-testing-info
Focuses: multisite Cc:



If in the reading settings of the site, i chose to list my latest posts as the home page: going on wp-signup.php or wp-activate.php will query & fetch the 10 latests posts for nothing in a way. Moreover In this case is_home() is true which is a bit confusing.

If in the reading settings of the site, i chose a static front page as the home page, it will be requested and fetched when going on wp-signup.php or wp-activate.php. In this case is_page() is true which is less confusing.

So i guess, the particularity of these two specific pages is they're getting the header and the footer of the active theme.

But i wonder why running wp() ?

By simply directly loading the wp-includes/template-loader.php it can save a query.

see signup-activate-1.patch

If running wp() is required for a reason i don't see, a query could still be saved and it could be interested to use this to set a "page" title for the <title> tag.

see signup-activate-2.patch

Attachments (4)

signup-activate-1.patch (1.4 KB) - added by imath 7 years ago.
signup-activate-2.patch (4.9 KB) - added by imath 7 years ago.
39703.1.patch (1.1 KB) - added by sabernhardt 23 months ago.
39703.2.patch (4.8 KB) - added by sabernhardt 23 months ago.

Download all attachments as: .zip

Change History (9)

#1 @johnjamesjacoby
7 years ago

This is interesting. Good find.

I can't think of a problem with this, other than someone doing something weird that would still require the $wp_did_header check.

#2 @imath
7 years ago

  • Keywords has-patch added

#3 @swissspidy
7 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

#4 @sabernhardt
23 months ago

I refreshed the patches for both options. I like having a special title for each page (option 2).

#5 @poena
3 months ago

  • Keywords needs-testing-info added
  • Milestone changed from Future Release to 6.6
Note: See TracTickets for help on using tickets.