WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39705 closed task (blessed) (fixed)

Reverse the order in which the Travis jobs run

Reported by: johnbillion Owned by: netweb
Milestone: 4.8 Priority: low
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

The Travis jobs within a build run in the order in which they're specified in .travis.yml. This means that the WordPress tests run on the oldest version of PHP first (5.2) and the newest version last (7.1). As a general rule, this means the slowest test jobs run first because each subsequent version of PHP is faster than the previous.

This order should be reversed so that when a committer is patiently waiting for a Travis build to complete, they are at least more likely to see unexpected failures earlier than they otherwise would.

The disadvantage is that 5.2-specific failures would take longer to appear, but these are relatively infrequent.

Attachments (3)

39705.patch (746 bytes) - added by johnbillion 3 years ago.
39705.1.diff (753 bytes) - added by netweb 3 years ago.
39705.2.diff (755 bytes) - added by netweb 3 years ago.

Download all attachments as: .zip

Change History (22)

#1 @aaroncampbell
3 years ago

Just weighing here that I think this is a good idea, and I think the change should be backported as well. At least across the versions we're still doing security updates for.

#2 @netweb
3 years ago

  • Owner set to netweb
  • Status changed from new to accepted

Agreed, makes sense, I did this for bbPress a while ago in bbpress:changeset:6005

First up though I think we should get stranger-node-things.diff from #35105 in, this should fix all the Travis CI branch builds from erroring then we can reorder the PHP versions in the build matrix.

#3 @johnbillion
3 years ago

#39486 should go in too in one form or another.

@johnbillion
3 years ago

#4 follow-up: @johnbillion
3 years ago

  • Keywords has-patch added; needs-patch removed

39705.patch is my proposed order. The patch will conflict with @netweb's patch on #35105 though.

#5 in reply to: ↑ 4 @netweb
3 years ago

  • Keywords needs-patch added; has-patch removed

Replying to johnbillion:

39705.patch is my proposed order.

We want to keep the current top/first job in the same position, it's the JavaScript only job that typically finishes in under 2 minutes, this also keeps within the original ticket proposal of the fastest job first.

That job for reference is this job:

  - php: 7 
    env: WP_TRAVISCI=travis:js 

Replying to johnbillion:

The patch will conflict with @netweb's patch on #35105 though.

That it will, and we should also in this ticket backport as much of this as possible to branches back to 3.7, as such rather than having to refresh the patch in #35105 it'd be nice to get that committed first and then update the patch here

@netweb
3 years ago

#6 @netweb
3 years ago

  • Keywords has-patch commit added; needs-patch removed

Refreshed patch per my comment above, keeps the JavaScript only test the first Travis CI job of each build, also bumps the PHP version used in that job to the latest stable PHP version, PHP 7.1

Note: Will still conflict with #35105 patch ;)

@netweb
3 years ago

#7 @netweb
3 years ago

Patch 39705.2.diff is a refresh of 39705.1.diff to apply cleanly against /trunk

#8 @johnbillion
3 years ago

In 40434:

Build/Test tools: Reverse the order in which the Travis jobs run.

As a general rule, this means the fastest test jobs now run first because each subsequent version of PHP is faster than the previous. When a committer is patiently waiting for a Travis build to complete, they are at least more likely to see unexpected failures earlier than they otherwise would.

In addition, this updates the JavaScript test job to run on PHP 7.1.

Props netweb

See #39705

#9 @johnbillion
3 years ago

In 40435:

Build/Test tools: Reverse the order in which the Travis jobs run.

As a general rule, this means the fastest test jobs now run first because each subsequent version of PHP is faster than the previous. When a committer is patiently waiting for a Travis build to complete, they are at least more likely to see unexpected failures earlier than they otherwise would.

In addition, this updates the JavaScript test job to run on PHP 7.1.

Props netweb

See #39705

Merges [40434] to the 4.7 branch.

#10 @johnbillion
3 years ago

In 40436:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.6 branch.

See #39705

#11 @johnbillion
3 years ago

In 40437:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.5 branch.

See #39705

#12 @johnbillion
3 years ago

In 40438:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.4 branch.

See #39705

#13 @johnbillion
3 years ago

In 40439:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.3 branch.

See #39705

#14 @johnbillion
3 years ago

In 40440:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.2 branch.

See #39705

#15 @johnbillion
3 years ago

In 40441:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.1 branch.

See #39705

#16 @johnbillion
3 years ago

In 40442:

Build/Test tools: Reverse the order in which the Travis jobs run on the 4.0 branch.

See #39705

#17 @johnbillion
3 years ago

In 40443:

Build/Test tools: Reverse the order in which the Travis jobs run on the 3.9 branch.

See #39705

#18 @johnbillion
3 years ago

In 40444:

Build/Test tools: Reverse the order in which the Travis jobs run on the 3.8 branch.

See #39705

#19 @johnbillion
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.