WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39727, comment 3


Ignore:
Timestamp:
01/30/2017 08:28:34 PM (3 years ago)
Author:
jnylen0
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39727, comment 3

    initial v1  
    1 I think I am -1 on this.  Unit tests should use `$request->set_query_param`, and WP code should use `$request->get_query_param` or `$request['param_name']`.  If there are code paths that are doing something else (like #39696 where `WP_REST_Server` checks `$_GET` directly) then they should be converted to use regular request parameters instead.
     1I think I am -1 on this.  Unit tests should use `$request->set_param`, and WP code should use `$request->get_param` or just `$request['param_name']`.  If there are code paths that are doing something else (like #39696 where `WP_REST_Server` checks `$_GET` directly) then they should be converted to use regular request parameters instead.