WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#39737 closed defect (bug) (fixed)

Correct deprecated version number

Reported by: grapplerulrich's profile grapplerulrich Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.8 Priority: normal
Severity: normal Version: 3.0
Component: Administration Keywords: has-patch
Focuses: docs Cc:

Description (last modified by swissspidy)

The second parameter for xfn_check() was deprecated in version 2.5.

Here is the changeset when that was done: [6354]

I have set the version to 3.0 as the deprecated version was incorrectly set to 0.0 in that version.
https://core.trac.wordpress.org/ticket/11386#comment:32

Attachments (1)

39737.diff​ (563 bytes) - added by grapplerulrich 6 years ago.

Download all attachments as: .zip

Change History (8)

@grapplerulrich
6 years ago

#1 @grapplerulrich
6 years ago

  • Keywords has-patch added

#2 @swissspidy
6 years ago

  • Description modified (diff)

#3 @SergeyBiryukov
6 years ago

  • Component changed from XML-RPC to Administration
  • Milestone changed from Awaiting Review to 4.8

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 40029:

Link Manager: Correct version number for _deprecated_argument() in xfn_check().

Props grapplerulrich.
Fixes #39737.

#5 @grapplerulrich
6 years ago

@SergeyBiryukov The inline comment needs to be removed too as it is incorrect.

#6 @SergeyBiryukov
6 years ago

@grapplerulrich $type was added along with the function in [2051], but never used, so the comment appears to be accurate. There are similar comments in safecss_filter_attr()​ and get_last_updated()​, so I thought this one might be worth keeping as well.

#7 @grapplerulrich
6 years ago

Ok, in that case it makes sense.

Note: See TracTickets for help on using tickets.