#39783 closed defect (bug) (fixed)
Requests http_api_curl action doesn't pass $handle by reference
Reported by: | pento | Owned by: | dd32 |
---|---|---|---|
Milestone: | 4.7.3 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | HTTP API | Keywords: | has-patch has-unit-tests commit |
Focuses: | Cc: |
Description
The Requests compatibility layer for the http_api_curl
action was introduced in [39212].
Historically, the $handle
parameter has been passed by reference, but the call in WP_HTTP_Requests_Hooks::dispatch()
doesn't do that.
Attachments (2)
Change History (10)
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
#3
@
8 years ago
Bringing the newer call into compliance with the existing one and the filter docs seems like a good idea to me.
cc @rmccue @dd32 since you worked on #37843 - one of you want to take this one for 4.7.3?
#4
@
8 years ago
- Keywords commit added
Since this has only been broken in 4.7.x I don't see the harm in fixing it, a pure oversight.
#6
@
8 years ago
Cross-referencing - Reporter in #39872 reports that this patch fixes the issue for them.
Note: See
TracTickets for help on using
tickets.
The test has a fake assert, because it's actually testing for a PHP error. :-)