WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39784 closed enhancement (duplicate)

Add jquery dependency to admin-bar.js

Reported by: rellect Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7.2
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

The admin-bar.js contains two implementations, one in vanilla js and the other in jquery.
I'm suggesting adding jquery dependency to admin-bar.js, for two reasons:

  1. Looking at the recent changes in the file, only the jquery implementation is maintained.
  2. It's common practice to move jquery (and other js files) to footer, causing admin-bar.js to be loaded before jquery is available.

Attachments (1)

39784.patch (691 bytes) - added by rellect 3 years ago.

Download all attachments as: .zip

Change History (3)

@rellect
3 years ago

#1 @rellect
3 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Toolbar
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Hi @rellect, thanks for the ticket!

We're already tracking this enhancement in #19979.

Note: See TracTickets for help on using tickets.