WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Last modified 9 months ago

#39787 new enhancement

wp_list_authors can be optimize

Reported by: alexufo's profile alexufo Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.8
Component: Users Keywords: has-patch dev-feedback has-unit-tests
Focuses: Cc:

Description

May be i don't understand but look at this line

https://core.trac.wordpress.org/browser/tags/4.7/src/wp-includes/author-template.php#L392

 392                    $author = get_userdata( $author_id );

Why we should call get_userdata()? At top we call $authors = get_users( $query_args ); and can return display_name and user_nicename in next foreach section without get_userdata().

And will be nice add filter by role. Because wp_list_authors means authors not subscribers or editors.

Attachments (1)

39787.diff​ (2.9 KB) - added by theskinnyghost 5 years ago.
function changes + unit tests

Download all attachments as: .zip

Change History (4)

#1 @Hareesh Pillai
5 years ago

  • Keywords needs-patch added

@theskinnyghost
5 years ago

function changes + unit tests

#3 @theskinnyghost
5 years ago

  • Keywords has-patch dev-feedback has-unit-tests added; needs-patch removed

Hi,

I hope I understood the filtering requirement correctly.

Thanks,
Luca

Note: See TracTickets for help on using tickets.