WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#3981 closed enhancement (fixed)

Patch: Improve error propagation from newMediaObject failure in xmlrpc.php

Reported by: redsweater Owned by:
Milestone: 2.1.3 Priority: high
Severity: normal Version: 2.1.2
Component: XML-RPC Keywords: has-patch
Focuses: Cc:

Description

I'm the developer of MarsEdit, a Mac desktop blogging application that works with WordPress. When my customers have trouble with the "upload image" functionality, the error responses from WordPress are lackluster. I tracked this down to a simple failure case in xmlrpc.php where the verbose error returned by wp_upload_bits is not being propagated out to the response text.

I'm attaching a proposed diff which addresses this. The diff is against /trunk/ as of today, but I would really love to see this integrated into the 2.1.x branch, because it will have a major impact on my customers' ability to debug MarsEdit interoperability with their WordPress blog.

Daniel Jalkut
Red Sweater Software

Attachments (1)

xmlrpc.php.diff (623 bytes) - added by redsweater 7 years ago.
Diffs to enhance verbose error propagation from newMediaObject failure.

Download all attachments as: .zip

Change History (5)

redsweater7 years ago

Diffs to enhance verbose error propagation from newMediaObject failure.

comment:1 foolswisdom7 years ago

  • Keywords has-patch added
  • Milestone changed from 2.3 to 2.2
  • Priority changed from normal to high

comment:2 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5054]) Improve error propagation from newMediaObject failure in xmlrpc.php. Props Daniel Jalkut (Red Sweater Software). fixes #3981 for 2.2

comment:3 ryan7 years ago

(In [5055]) Improve error propagation from newMediaObject failure in xmlrpc.php. Props Daniel Jalkut (Red Sweater Software). fixes #3981 for 2.1

comment:4 ryan7 years ago

  • Milestone changed from 2.2 to 2.1.3

This is a small, confined change so let's include it in 2.1.3. 2.1.3 RC2 is coming today. Let's make sure we test this out before 2.1.3 final.

Note: See TracTickets for help on using tickets.