Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#39823 closed defect (bug) (fixed)

Added documentation to inline-edit-post.js

Reported by: jjcomack Owned by: obenland
Priority: normal Milestone: 4.8
Component: Quick/Bulk Edit Version:
Severity: normal Keywords: has-patch
Cc: Focuses: javascript, docs

Description

As part of Yoast's continous efforts to improve the JavaScript documentation, this patch adds documentation that was missing in inline-edit-post.js.

Props to @rensw90 for doing this.

Attachments (2)

js_doc-inline_edit_post.diff.zip​ (3.8 KB ) - added by jjcomack 10 years ago.
js_doc-inline_edit_post.diff​ (11.5 KB ) - added by jjcomack 10 years ago.

Download all attachments as: .zip

Change History (9)

#1 follow-up: @SergeyBiryukov
10 years ago

  • Milestone Awaiting Review → 4.8

Hi @jjcomack, thanks for the patch (and thanks to @rensw90 as well)!

For easier review, could you attach the .diff file itself, not in an archive?

#2 in reply to: ↑ 1 @jjcomack
10 years ago

Replying to SergeyBiryukov:

Hi @jjcomack, thanks for the patch (and thanks to @rensw90 as well)!

For easier review, could you attach the .diff file itself, not in an archive?

Oh, of course! Sorry, I was instructed to upload this. Will get right on it!

#3 @jjcomack
10 years ago

@SergeyBiryukov Done :)

#4 @ketuchetan
9 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by obenland. ​View the logs.


9 years ago

#6 @obenland
9 years ago

  • Owner set to obenland
  • Status new → accepted

#7 @obenland
9 years ago

  • Resolution → fixed
  • Status accepted → closed

In 40796:

Docs: Improve inline docs for inlineEditPost.

Props jjcomack, rensw90.
Fixes #39823.

Note: See TracTickets for help on using tickets.