WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#39823 closed defect (bug) (fixed)

Added documentation to inline-edit-post.js

Reported by: jjcomack's profile jjcomack Owned by: obenland's profile obenland
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Quick/Bulk Edit Keywords: has-patch
Focuses: javascript, docs Cc:

Description

As part of Yoast's continous efforts to improve the JavaScript documentation, this patch adds documentation that was missing in inline-edit-post.js.

Props to @rensw90 for doing this.

Attachments (2)

js_doc-inline_edit_post.diff.zip​ (3.8 KB) - added by jjcomack 8 years ago.
js_doc-inline_edit_post.diff​ (11.5 KB) - added by jjcomack 8 years ago.

Download all attachments as: .zip

Change History (9)

@jjcomack
8 years ago

#1 follow-up: @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.8

Hi @jjcomack, thanks for the patch (and thanks to @rensw90 as well)!

For easier review, could you attach the .diff file itself, not in an archive?

#2 in reply to: ↑ 1 @jjcomack
8 years ago

Replying to SergeyBiryukov:

Hi @jjcomack, thanks for the patch (and thanks to @rensw90 as well)!

For easier review, could you attach the .diff file itself, not in an archive?

Oh, of course! Sorry, I was instructed to upload this. Will get right on it!

@jjcomack
8 years ago

#3 @jjcomack
8 years ago

@SergeyBiryukov Done :)

#4 @ketuchetan
8 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by obenland. ​View the logs.
8 years ago

#6 @obenland
8 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#7 @obenland
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 40796:

Docs: Improve inline docs for inlineEditPost.

Props jjcomack, rensw90.
Fixes #39823.

Note: See TracTickets for help on using tickets.