Blogroll link adding should use clean_url()

[nateomedia]

Image Address under Blogroll > Add Link now appends "​http://" to the front of all URL addresses. This thwarts the use of relative links and is a change in behavior from previous versions. There's no good reason for this behavioral change and it should be corrected.

[foolswisdom]

Likely relates to #4001.

[rob1n]

For starters, I don't see *why* you would be using relative URI's in your blogroll, but that aside, I agree that this "default behavior" should be changed.

Also, I think blogrolls should use clean_url() not the plain regex that is on line 614 of admin-functions.php. I'll fix this.

[rob1n]

Patch changes edit_link() (which is called by add_link()) to use clean_url(), and also use clean_url() on the RSS link (if it's not empty).

[rob1n]

Take out empty check.

[ryan]

(In [5068]) Use clean_url instead of inline preg. Props rob1n. fixes #3983 for trunk

[ryan]

(In [5069]) Use clean_url instead of inline preg. Props rob1n. fixes #3983 for 2.1

[ryan]

Maybe clean_url only REQUEST_URI, which should begin with a slash, and not clean_url the edit-users.php link.

[ryan]

Code in question is in user_row() in admin-functions.php BTW. We'll need to check other places too.

[rob1n]

For the 2.0 branch.

[rob1n]

Reopen for 2.0.

[ryan]

(In [5070]) Use clean_url instead of inline preg. Props rob1n. fixes #3983 for 2.0