Make WordPress Core

Opened 5 years ago

Last modified 2 years ago

#39831 new enhancement

Theme Tag Translation Ready

Reported by: rinkuyadav999 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: administration Cc:


As i read, All theme text strings are to be translatable. > https://make.wordpress.org/themes/handbook/review/required/#language

In that case, seems it is compulsory and there is not any use of 'translation-ready' theme tag. Because all themes on directory should be translation ready. if we apply filter with 'translation-ready' checkbox, it will return all themes.

Attachments (3)

39831#.patch (1.1 KB) - added by rinkuyadav999 5 years ago.
Core side changes
functions.php.patch (763 bytes) - added by rinkuyadav999 5 years ago.
39831-themes-api.diff (725 bytes) - added by dingo_d 2 years ago.
Remove the translation ready tag from the themes API

Download all attachments as: .zip

Change History (15)

5 years ago

Core side changes

#2 @grapplerulrich
5 years ago

This change makes sense. The theme review team is planning on having a new look at the theme tags again and it would be best for this tag to removed then as we make other changes then just this on it's own.

#3 @swissspidy
5 years ago

  • Milestone changed from Awaiting Review to Future Release

#4 @swissspidy
5 years ago

  • Keywords has-patch added
  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

This ticket was mentioned in Slack in #themereview by rinkuyadav999. View the logs.

5 years ago

#6 @greenshady
5 years ago

I don't think themes that haven't been updated in 2 years show up in search results, and we've required that themes be translation ready for 2 years now: https://make.wordpress.org/themes/2014/12/09/theme-review-team-weekly-notes-the-logs-are-3/

So, it should probably safe at this point to remove the tag as it's a standard feature.

This ticket was mentioned in Slack in #themereview by jcastaneda. View the logs.

5 years ago

#8 @rinkuyadav999
2 years ago

Hi @SergeyBiryukov 

Please close the ticket. it is already fixed.


#9 @dingo_d
2 years ago

@rinkuyadav999 you said it's fixed but I can see the translation-ready tag in the themes api and in the response


Should this be closed?

#10 @rinkuyadav999
2 years ago

@dingo_d Yes, it is removed from theme tags and also from WordPress core theme filters. you can close the ticket.

#11 @dingo_d
2 years ago

The api still shows the tags, so this needs to be fixed as well. I think I know where to fix this so I'll make a patch probably next week since I'm out of country.

2 years ago

Remove the translation ready tag from the themes API

#12 @dingo_d
2 years ago

I've added the patch to remove the translation ready tag from the themes API. Once this is merged we can close the ticket.

Note: See TracTickets for help on using tickets.