WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 6 years ago

#39838 closed defect (bug) (wontfix)

Twenty Fifteen: Use wp_enqueue_script() for html5.js

Reported by: rinkuyadav999 Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version: 4.2
Severity: normal Keywords: needs-patch
Cc: Focuses:

Description

twentyfifteen: script file should use wp_enqueue_script and translation issue.

Attachments (1)

39838#.patch​ (2.3 KB ) - added by rinkuyadav999 10 years ago.

Download all attachments as: .zip

Change History (6)

@rinkuyadav999
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Component Themes → Bundled Theme
  • Focuses performance removed
  • Summary twentyfifteen TRT sniff issues → Twenty Fifteen: Use wp_enqueue_script() for html5.js

The "One thought on ..." issue should be resolved in #39660.

#2 @SergeyBiryukov
10 years ago

Using wp_enqueue_script() for html5.js was previously suggested in #30810, but that was before conditional comments for JS became available (#16024), so we could probably take another look.

There are backwards compatibility concerns though, conditional comments for JS are only available in WordPress 4.2+, and Twenty Fifteen should remain compatible with WordPress 4.1.

#3 @rinkuyadav999
10 years ago

@SergeyBiryukov

Yes, we need to maintain compatibility.

#4 @swissspidy
10 years ago

  • Keywords needs-patch added
  • Version trunk → 4.2

#5 @ianbelanger
6 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

I'm going to close this out as wontfix since there are back compat concerns with changing the way html5.js is added. Please feel free to reopen if you disagree.

Note: See TracTickets for help on using tickets.