WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 5 months ago

#39838 new defect (bug)

Twenty Fifteen: Use wp_enqueue_script() for html5.js

Reported by: rinkuyadav999 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.2
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

twentyfifteen: script file should use wp_enqueue_script and translation issue.

Attachments (1)

39838#.patch (2.3 KB) - added by rinkuyadav999 6 months ago.

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
6 months ago

  • Component changed from Themes to Bundled Theme
  • Focuses performance removed
  • Summary changed from twentyfifteen TRT sniff issues to Twenty Fifteen: Use wp_enqueue_script() for html5.js

The "One thought on ..." issue should be resolved in #39660.

#2 @SergeyBiryukov
6 months ago

Using wp_enqueue_script() for html5.js was previously suggested in #30810, but that was before conditional comments for JS became available (#16024), so we could probably take another look.

There are backwards compatibility concerns though, conditional comments for JS are only available in WordPress 4.2+, and Twenty Fifteen should remain compatible with WordPress 4.1.

#3 @rinkuyadav999
6 months ago

@SergeyBiryukov

Yes, we need to maintain compatibility.

#4 @swissspidy
5 months ago

  • Keywords needs-patch added
  • Version changed from trunk to 4.2
Note: See TracTickets for help on using tickets.