![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Last modified 8 days ago
#39844 new enhancement
Don't return anchor tag if link is empty in get_the_author_posts_link()
| Reported by: | SirkoSchindler | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Themes | Version: | 4.7.2 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | template |
Description
If get_author_posts_url() returns an empty value, currently get_the_author_posts_link() creates an anchor tag with am empty target. If shown on the page this results in a link to the current page, which is not what is expected from an author link.
https://core.trac.wordpress.org/browser/tags/4.7.2/src/wp-includes/author-template.php#L252
The attached patch changes this, so that if no link is given, just the author name is returned with no anchor tag surrounding.
This is in line with the respective code for get_comment_author_link()
https://core.trac.wordpress.org/browser/tags/4.7.2/src/wp-includes/comment-template.php#L216
Attachments (2)
Change History (8)
#4
@
4 years ago
To work on this, I removed and then changed the author's URL with the author_link hook:
add_filter( 'author_link', '__return_empty_string' );
add_filter( 'author_link', function(){ return 'http://'; } );
The patch is refreshed, but it still should have unit tests.
This ticket was mentioned in PR #12415 on WordPress/wordpress-develop by @sainathpoojary.
12 days ago
#5
Trac ticket: #39844
Any updates or comments on this?