Make WordPress Core

Opened 7 years ago

Last modified 2 years ago

#39844 new enhancement

Don't return anchor tag if link is empty in get_the_author_posts_link()

Reported by: sirkoschindler's profile SirkoSchindler Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.7.2
Component: Themes Keywords: has-patch needs-unit-tests
Focuses: template Cc:


If get_author_posts_url() returns an empty value, currently get_the_author_posts_link() creates an anchor tag with am empty target. If shown on the page this results in a link to the current page, which is not what is expected from an author link.

The attached patch changes this, so that if no link is given, just the author name is returned with no anchor tag surrounding.
This is in line with the respective code for get_comment_author_link()

Attachments (2)

author-template.php.patch (1.7 KB) - added by SirkoSchindler 7 years ago.
39844.diff (1.4 KB) - added by sabernhardt 2 years ago.

Download all attachments as: .zip

Change History (6)

#1 @swissspidy
7 years ago

  • Keywords has-patch added

#2 @SirkoSchindler
7 years ago

Any updates or comments on this?

#3 @swissspidy
7 years ago

  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to Future Release

2 years ago

#4 @sabernhardt
2 years ago

To work on this, I removed and then changed the author's URL with the author_link hook:

add_filter( 'author_link', '__return_empty_string' );
add_filter( 'author_link', function(){ return 'http://'; } );

The patch is refreshed, but it still should have unit tests.

Note: See TracTickets for help on using tickets.