Filter `nav_menu_items_{$post_type_name}_recent` passes base args, not recent

[eclev91]

On line 434 of nav-menu.php, the nav_menu_items_{$post_type_name}_recent filter is passing the base $args rather than the adjusted $recent_args set on line 418. Could be expected, but seemed odd to me and I ended up reapplying those arguments in my filter function.

If someone can confirm this is a bug and not as expected, I'd be happy to attach a patch.

[welcher]

@eclev91 thanks for reporting!

This does seem unexpected to me as well. It seems to me that the filter should have all of the args available to it.

[welcher]

@eclev91 I've added an initial patch and @johnbillion reviewed it with me.

The concern with my approach is that $args['walker'] is overridden after the array merge and doesn't exist in the $recent_args array. We both agreed that it may be better to add a fourth argument to the filter that holds $recent_args instead.

Would you like to apply those changes?

[eclev91]

While it's been a while since I ran into this, I think the proposed solution makes sense. As long as those arguments are available and how to get them is documented.

[welcher]

Adding recent_args as a fourth param

[SergeyBiryukov]

In 41941:

Menus: Pass $recent_args parameter to nav_menu_items_{$post_type_name}_recent filter.

Props welcher, eclev91.
Fixes #39849.