WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #39859, comment 9


Ignore:
Timestamp:
11/03/2017 11:06:25 PM (4 years ago)
Author:
andreiglingeanu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39859, comment 9

    v1 v2  
    55Everything works as expected but I do have two questions:
    66
    7 1. I'm not really able to easily add the `aria-labelledby` attribute that will point to the visible heading in the modal. That's because sometimes, this blueprint Backbone View is used as part of other modals, which may or may not have a heading. That is, I would need to introduce a conditional somehow in the `media-modal` underscore template for deciding whether to insert or not that attribute. Is that something that ''really'' needs to be done? See [that](https://github.com/ThemeFuse/Unyson/pull/2388) third-party plugin where this widget is used as part of another UI element.
     71. I'm not really able to easily add the `aria-labelledby` attribute that will point to the visible heading in the modal. That's because sometimes, this blueprint Backbone View is used as part of other modals, which may or may not have a heading. That is, I would need to introduce a conditional somehow in the `media-modal` underscore template for deciding whether to insert or not that attribute. Is that something that ''really'' needs to be done? See [https://github.com/ThemeFuse/Unyson/pull/2388 this third-party] plugin where this widget is used as part of another UI element.
    88
    992. I'm getting back to the `_freeze` option for the `wp.media.view.Modal`, which I described back in the original description. Is that something I should remove as part of resolving that ticket? I feel like that was a hack around this wrongly focused element which caused the browser to jump back and forth.