add unit tests for wp_validate_boolean() in function.php

[pbearne]

just some more unit tests

[pbearne]

unit tests

[desrosj]

Thanks for this, @pbearne!

It seems that there is already a class for testing wp_validate_boolean(), but your data provider method has some additional scenarios that are not currently tested.

39868.diff​ combines the preexisting conditions with your added tests, replaces individual methods with a data provider method, and improves some of the documentation.

See #30238 for the original test class introduction.

[desrosj]

In 46159:

Build/Test Tools: Improve test coverage for wp_validate_boolean().

This change also reworks the test class to use a data provider.

Props pbearne, desrosj
Fixes #39868

[jrf]

This patch has changed the test to a loose type comparison of the $result to $expected which will allow for type juggling and basically means the method is not actually being tested correctly anymore. I'll upload a patch shortly to fix this.

Refs:

• ​https://phpunit.de/manual/6.5/en/appendixes.assertions.html#appendixes.assertions.assertEquals
• ​https://phpunit.de/manual/6.5/en/appendixes.assertions.html#appendixes.assertions.assertSame

[jrf]

[tests] WpValidateBoolean: fix assertion

[SergeyBiryukov]

In 46224:

Tests: Correct assertion in test_wp_validate_boolean() to make sure the return type is properly tested.

Props jrf.
Fixes #39868.

[jrf]

Thanks @SergeyBiryukov !