WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39883, comment 23


Ignore:
Timestamp:
05/20/2017 08:11:54 PM (8 years ago)
Author:
joemcgill
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #39883, comment 23

    initial v1  
     1[Update: fixed link to correct patch]
     2
    13As I understand it, there were essentially two main problems introduced in r38949:
    241. Non-image attachment IDs are now passed to the `image_downsize` filter, where they previously weren't.
    … …  
    57Of those two, the second seems to be the most important to address, since there's no way for a developer to avoid this on their own, as @stephdau helpfully explained in the description of this issue.
    68
    7 [attachment:39883.diff] resolves the second problem and partially addresses the first by only passing supported types to the filter. Here are my current assumptions:
     9[attachment:39883.2.diff] resolves the second problem and partially addresses the first by only passing supported types to the filter. Here are my current assumptions:
    810
    911* `wp_get_attachment_image_src()` (and related functions) should be able to take a post ID for a PDF and produce image attributes (Since 4.7).