Right after delete author - PHP notices on '%s is currently editing'

[esemlabel]

After deleting autor, who has just edited some post, the error will occur in the next few minutes in posts list table:

PHP Notice: Trying to get property of non-object in \wp-admin\includes\class-wp-posts-list-table.php on line 910

$locked_text = esc_html( sprintf( __( '%s is currently editing' ), $lock_holder->display_name ) );

Need some fix to immediately remove edit_lock meta with deleted author id from posts.

[esemlabel]

Maybe need both to remove: _edit_lock and _edit_last or just _edit_last, which contains user ID

[SergeyBiryukov]

wp_check_post_lock() could check if the user ID exists and return false otherwise.

[arshidkv12]

If user not exist return false

[1naveengiri]

Since $lock_holder = get_userdata( $lock_holder ); will return false if user id userid not exit.

[1naveengiri]

Since $lock_holder = get_userdata( $lock_holder ); will return false if user id userid not exit. and the rest functionality will work as expected.

[1naveengiri]

This will be the right cure to handle this situation.

[1naveengiri]

Please have a look on this.

[1naveengiri]

@SergeyBiryukov could you set props for this bug. If it is fixed.

[SergeyBiryukov]

Tickets are fixed when a commit is made to WordPress trunk.

[1naveengiri]

okey

Replying to SergeyBiryukov:

Tickets are fixed when a commit is made to WordPress trunk.

[swissspidy]

@1naveengiri There was no commit yet, which means the ticket is not fixed yet and your patch will be considered for fixing it. So don't worry.

[1naveengiri]

Hi Team,
any update on above Bug Fix.

[swissspidy]

Latest patch looks fine to me.

[SergeyBiryukov]

wp_check_post_lock() is used in a few more places, so I still think 39888.1.diff​ would be the correct fix here.

[SergeyBiryukov]

In 40423:

Posts, Post Types: Improve the docs for wp_check_post_lock() and wp_set_post_lock().

See #39888.

[SergeyBiryukov]

In 40424:

Posts, Post Types: In wp_check_post_lock(), check if the user with lock exists and return false otherwise.

Props arshidkv12, 1naveengiri.
Fixes #39888.