Empty if-statement

[appchecker]

Hello!

In this ​code fragment:

<?php
        if ( $markerdata = explode( "\n", implode( '', file( $filename ) ) ));
        {
                $state = false;
                ....
        }

Body of if-statement actually is empty. Probably, semicolon is excess.

This possible defect found with ( ​AppChecker )

[yahil]

Is this what you are talking about?

[SergeyBiryukov]

Hi @appchecker, welcome to WordPress Trac! Thanks for the report.

Good catch, introduced in [1489]. Would be great to have some unit tests for this (related: #26829).

[Dency]

added Empty if-statement

[Dency]

Hi @SergeyBiryukov,

I have added Empty if-statement before foreach otherwise it generates error and adds explode line before the empty statement.

Thanks,

[ketuchetan]

Hi @Dency

Have you tested your patch in unit testing?

Thanks,

[chesio]

Hi,

This could be solved with a patch I just submitted for #26829 (comes with unit tests too).

[SergeyBiryukov]

In 41928:

Rewrite Rules: Remove redundant if condition in extract_from_markers().

Props Dency, yahil, appchecker.
Fixes #39920.

[SergeyBiryukov]

In 42199:

Rewrite Rules: Correct the logic in extract_from_markers() after [41928].

Props stodorovic.
Fixes #42579. See #39920.

[dd32]

In 42213:

Rewrite Rules: Correct the logic in extract_from_markers() after [41928].

Props stodorovic, SergeyBiryukov.
Merges [42199] to the 4.9 branch.
Fixes #42579. See #39920.