WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39941, comment 60


Ignore:
Timestamp:
10/20/2020 07:05:35 PM (5 years ago)
Author:
ocean90
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #39941, comment 60

    initial v1  
    66* `sprintf( ' %1$s="%1$s"', $attribute_name );`: shouldn't the value escaped with `esc_attr()` for conistencety?
    77* The nested conditions for the boolean attributes should probably be combined to `is_bool( $attribute_value ) && $attribute_value`
     8* I think we should hold off on committing the patch as this without any actual use of the new functions in core, especially late in this cycle.