WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39945, comment 2


Ignore:
Timestamp:
02/28/2017 04:24:58 AM (3 years ago)
Author:
biisent
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39945, comment 2

    initial v1  
    11Two considerations:
    22
    3 1. When `$this->is_feed == true` and `$this->is_singular == false`, then `$q['posts_per_page']` is set to `$q['posts_per_rss']` and `$q['paging']` is set to `false` in https://core.trac.wordpress.org/browser/branches/4.7/src/wp-includes/class-wp-query.php#L1768 . This however prevents the later sanitization of `$q['nopaging']` since it is only performed when `!isset($q['nopaging'])`.
     31. When `$this->is_feed == true` and `$this->is_singular == false`, then `$q['posts_per_page']` is set to `$q['posts_per_rss']` and `$q['nopaging']` is set to `false` in https://core.trac.wordpress.org/browser/branches/4.7/src/wp-includes/class-wp-query.php#L1768 . This however prevents the later sanitization of `$q['nopaging']` since it is only performed when `!isset($q['nopaging'])`.
    44
    552. In my opinion, retrieving all posts for negative posts_per_page values seems consistent. However it may break compatibility (?) as currently negative posts_per_page values <= -2 will just become positive.