Remove direct calls to '/tmp/' in Unit Tests

[joemcgill]

As noted by @mikeschroder in 39875, there are several places in our unit tests where we assume the temp directory is '/tmp/' and make direct calls. Instead, we should use something like wp_tempnam() to ensure we're writing and removing files from the right place during tests.

[DJPaul]

Please see 39975.01.patch which makes the requested change. There is one whitespace change (space at the end of the line) accidentally included.

[netweb]

Testing 39975.01.patch​ ​https://github.com/aaronjorbin/develop.wordpress/pull/49

Travis CI job: ​https://travis-ci.org/aaronjorbin/develop.wordpress/builds/227250259

[netweb]

Related, possible duplicate: #40856

[christophherr]

Replaces three additional occurrences of /tmp in phpunittests/widgets

[christophherr]

Removes symlinks from phpunit/tests/link/themeFile.php using parts of @danielhueskens patch on #40856

[christophherr]

This would greatly improve the unit test experience on Windows.

39975.2 replaces additional usages of /tmp from three files in phpunit/tests/widgets
39975.1 and 30075.2 remove 157 errors.

39975.3 replaces symlinks from phpunit/tests/link/themeFile.php using parts of @danielhuesken 's patch on #40856.
On Windows 10 with PHP 7.1.11, this removes the following warnings:

Warning: unlink(C:\laragon\www\trunk/src/wp-content\themes\theme-file-parent): Permission denied in C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php on line 13

Warning: unlink(C:\laragon\www\trunk/src/wp-content\themes\theme-file-child): Permission denied in C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php on line 14

and also avoids additional warnings when the tests are run again (because unlink didn't remove the symlink in the previous run) :

Warning: symlink(): Cannot create symlink, error code(183) in C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php on line 8

Warning: symlink(): Cannot create symlink, error code(183) in C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php on line 9

6 failures remain after 39975.3:

1) Tests_WP_Customize_Manager::test_import_theme_starter_content
Expected reuse of non-auto-draft attachment.
Failed asserting that an array contains 914.

C:\laragon\www\trunk\tests\phpunit\tests\customize\manager.php:644

2) Tests_DB::test_mysqli_flush_sync
procedure could not be created (missing privileges?)

C:\laragon\www\trunk\tests\phpunit\tests\db.php:621

3) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #0 ('parent-only.php', 'theme-file-parent', array('theme-file-parent'))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-''
+'C:\laragon\www\trunk\tests\phpunit\includes/../data/themedir1/default/parent-only.php'

C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php:117

4) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #1 ('child-only.php', 'theme-file-child', array('theme-file-child'))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-''
+'C:\laragon\www\trunk\tests\phpunit\includes/../data/themedir1/default/child-only.php'

C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php:117

5) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #2 ('parent-and-child.php', 'theme-file-child', array('theme-file-parent', 'theme-file-child'))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-''
+'C:\laragon\www\trunk\tests\phpunit\includes/../data/themedir1/default/parent-and-child.php'

C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php:117

6) Test_Theme_File::test_theme_file_uri_returns_valid_uri with data set #3 ('neither.php', 'theme-file-parent', array())
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-''
+'C:\laragon\www\trunk\tests\phpunit\includes/../data/themedir1/default/neither.php'

C:\laragon\www\trunk\tests\phpunit\tests\link\themeFile.php:117

[Clorith]

#43038 was marked as a duplicate.

[birgire]

#44605 was marked as a duplicate.

[davidbaumwald]

Latest patch fails against trunk, so marking for a refresh.

[SergeyBiryukov]

In 48463:

Tests: Copy themes from tests/phpunit/data to wp-content/themes, instead of creating a symlink.

This allows the theme file tests in phpunit/tests/link/themeFile.php to run on Windows without requiring administrative privileges.

Follow-up to [42812], [42819].

Props danielhuesken, christophherr, davidbaumwald, SergeyBiryukov.
See #40856, #39975.

[SergeyBiryukov]

In 48464:

Tests: Replace hardcoded /tmp/ references with get_temp_dir().

This allows more tests to pass on Windows.

Props danielhuesken, DJPaul, christophherr, joemcgill, netweb, davidbaumwald, SergeyBiryukov.
Fixes #40856, #39975.

[SergeyBiryukov]

As noted in comment:4, [48463] uncovered a few theme file test failures that were previously skipped. These can be addressed either in follow-up commits here or in a new ticket.

[SergeyBiryukov]

Follow-up: #50664