WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39978 closed task (blessed) (fixed)

Disable Xdebug during tests on Travis

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:
PR Number:

Description

My local installation was running its tests 2x slower than I expected, and I narrowed down the problem to the Xdebug extension being unexpectedly enabled on the CLI. Disabling Xdebug restored the test suite speed back to its previous level.

I did some research and it turns out Xdebug can be disabled on Travis. Refs:

It would be worth pushing a change which disables Xdebug for core to see if it speeds things up (it should) and to see if it breaks anything (it shouldn't).

Attachments (1)

39978.diff (482 bytes) - added by johnbillion 3 years ago.

Download all attachments as: .zip

Change History (18)

@johnbillion
3 years ago

#1 @johnbillion
3 years ago

  • Keywords has-patch added; needs-patch removed

#2 @johnbillion
3 years ago

In 40138:

Build/Test Tools: Disable Xdebug when testing on Travis.

This should have some performance benefits, but I guess we'll need to wait and see.

See #39978

#3 @johnbillion
3 years ago

  • Owner set to johnbillion
  • Status changed from new to accepted

This worked better than I expected.

Total time on Travis has dropped from ~2h30 to ~1h30, and the actual build test time has dropped from ~40 mins to ~24 mins.

Need to fix the error that it's causing on hhvm and php nightly.

Ref: https://travis-ci.org/aaronjorbin/develop.wordpress/builds

#4 @johnbillion
3 years ago

In 40139:

Build/Test Tools: Only attempt to disable Xdebug on stable builds of PHP.

Unstable builds of PHP (nightly and hhvm) don't have the Xdebug extension enabled. Attempting to disable it results in a build error.

See #39978

#5 @johnbillion
3 years ago

  • Keywords has-patch removed
  • Resolution set to fixed
  • Status changed from accepted to closed

#6 @johnbillion
3 years ago

  • Keywords fixed-major added
  • Milestone changed from 4.8 to 4.7.4
  • Resolution fixed deleted
  • Status changed from closed to reopened

I think this is worth back-porting to the branches to speed up branch builds.

#7 @johnbillion
3 years ago

In 40225:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#8 @johnbillion
3 years ago

In 40226:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#9 @johnbillion
3 years ago

In 40227:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#10 @johnbillion
3 years ago

In 40228:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#11 @johnbillion
3 years ago

In 40229:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#12 @johnbillion
3 years ago

In 40230:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#13 @johnbillion
3 years ago

In 40231:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#14 @johnbillion
3 years ago

In 40232:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#15 @johnbillion
3 years ago

In 40233:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#16 @johnbillion
3 years ago

In 40234:

Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.

See #39978

#17 @johnbillion
3 years ago

  • Keywords fixed-major removed
  • Milestone changed from 4.7.4 to 4.8
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.