#39983 closed defect (bug) (fixed)
Consider to stop using the CSS class button-link for controls that don't look like links
Reported by: | afercia | Owned by: | afercia |
---|---|---|---|
Milestone: | 4.7.4 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Administration | Keywords: | has-screenshots has-patch commit fixed-major |
Focuses: | ui | Cc: |
Description
After [40059] the CSS class button-link
uses text-align: left
by default. This makes sense, since this class should be used to make buttons look like links. Browsers default stylesheets make text within buttons centered, so there's the need to make the text explicitly left aligned to prevent some edge cases, see for example #38712.
However, now the media modal "X" close button text is misplaced. Worth checking if the same thing happens for other buttons too. In these cases, text should be centered:
It's a minor visual glitch and can be easily fixed. Ideally, these buttons shouldn't use the button-link
class at all. They'd need just some reset of the default buttons CSS properties.
Attachments (2)
Change History (9)
#1
@
8 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.8
- Owner set to afercia
- Status changed from new to assigned
- Version set to 4.7
#2
@
8 years ago
39983.2.diff adds a few adjustments for the button text alignment in the Customizer and in the auth-check modal.
39983.diff removes the
button-link
CSS class from the media modal close button and adjusts the styles accordingly. Pending investigation about other edge cases.