Consider to don't use the CSS class button-link for controls that don't look like links
|Reported by:||afercia||Owned by:||afercia|
|Component:||Administration||Keywords:||has-screenshots has-patch commit fixed-major|
After  the CSS class button-link uses text-align: left by default. This makes sense, since this class should be used to make buttons look like links. Browsers default stylesheets make text within buttons centered, so there's the need to make the text explicitly left aligned to prevent some edge cases, see for example #38712.
However, now the media modal "X" close button text is misplaced. Worth checking if the same thing happens for other buttons too. In these cases, text should be centered:
It's a minor visual glitch and can be easily fixed. Ideally, these buttons shouldn't use the button-link class at all. They'd need just some reset of the default buttons CSS properties.
Change History (8)
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.8
- Owner set to afercia
- Status changed from new to assigned
- Version set to 4.7
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened