WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#39988 closed defect (bug) (fixed)

The theme used during tests should call wp_head() and wp_footer()

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.7.4 Priority: normal
Severity: normal Version: 4.7
Component: Build/Test Tools Keywords: fixed-major
Focuses: Cc:

Description

The wp_head() and wp_footer() functions are required for all themes, and it's safe to assume that all themes call these. The themedir1/default theme used in the tests (#31550) doesn't.

The effect that #31550 had was that it broke the tests in some of my plugins which assume that the current theme calls wp_footer(). This is a safe assumption to make, therefore the themedir1/default theme should call these functions.

Attachments (1)

39988.diff (320 bytes) - added by johnbillion 6 months ago.

Download all attachments as: .zip

Change History (5)

@johnbillion
6 months ago

#1 @johnbillion
6 months ago

  • Keywords has-patch added; needs-patch removed

#2 @johnbillion
6 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 40235:

Build/Test Tools: Call wp_head() and wp_footer() in the theme used during tests.

See #31550
Fixes #39988

#3 @johnbillion
6 months ago

  • Keywords fixed-major added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

#4 @johnbillion
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40236:

Build/Test Tools: Call wp_head() and wp_footer() in the theme used during tests.

See #31550
Fixes #39988

Merges [40235] to the 4.7 branch.

Note: See TracTickets for help on using tickets.