WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#40008 closed defect (bug) (fixed)

A multisite test (currently unknown) should remove added image thumbnails

Reported by: netweb's profile netweb Owned by: boonebgorges's profile boonebgorges
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch
Focuses: multisite Cc:

Description

After PHPUnit's multisite tests have run two files are not removed from the test/s that created them:

svn st
?       tests/phpunit/data/images/canola-150x150.jpg
?       tests/phpunit/data/images/canola-300x225.jpg

To reproduce:

Run grunt phpunit:multisite or https://develop.svn.wordpress.org/trunk followed by svn status

Attachments (1)

40008.diff​ (1.7 KB) - added by bor0 8 years ago.

Download all attachments as: .zip

Change History (6)

#1 @adamsilverstein
8 years ago

  • Keywords good-first-bug added

@bor0
8 years ago

#2 @bor0
8 years ago

  • Keywords has-patch added; needs-patch removed

Proposed patch does it similarly like other tests do (e.g. rest-attachments-controller.php)

#3 @netweb
8 years ago

  • Milestone changed from Future Release to 4.8

Thanks @bor0

#4 @boonebgorges
8 years ago

Technique looks good to me. Thanks for the patch, @bor0.

#5 @boonebgorges
8 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 40142:

Tests: Starter content tests should use copies of images stored in /tmp.

This ensures that generated thumbnails are kept out of the version-
controlled DIR_TESTDATA directory.

Props bor0.
Fixes #40008.

Note: See TracTickets for help on using tickets.