Context Navigation

← Previous Ticket
Next Ticket →

#40008 closed defect (bug) (fixed)

A multisite test (currently unknown) should remove added image thumbnails

Reported by:	netweb	Owned by:	boonebgorges
Priority:	normal	Milestone:	4.8
Component:	Build/Test Tools	Version:
Severity:	normal	Keywords:	good-first-bug has-patch
Cc:		Focuses:	multisite

Description

After PHPUnit's multisite tests have run two files are not removed from the test/s that created them:

svn st
?       tests/phpunit/data/images/canola-150x150.jpg
?       tests/phpunit/data/images/canola-300x225.jpg

To reproduce:

Run grunt phpunit:multisite or https://develop.svn.wordpress.org/trunk followed by svn status

Attachments (1)

40008.diff (1.7 KB ) - added by bor0 9 years ago.

Download all attachments as: .zip

Change History (6)

#1 @adamsilverstein
9 years ago

Keywords good-first-bug added

@bor0
9 years ago

Attachment 40008.diff added

#2 @bor0
9 years ago

Keywords has-patch added; needs-patch removed

Proposed patch does it similarly like other tests do (e.g. rest-attachments-controller.php)

#3 @netweb
9 years ago

Milestone Future Release → 4.8

Thanks @bor0

#4 @boonebgorges
9 years ago

Technique looks good to me. Thanks for the patch, @bor0.

#5 @boonebgorges
9 years ago

Owner set to boonebgorges
Resolution → fixed
Status new → closed

In 40142:

Tests: Starter content tests should use copies of images stored in /tmp.

This ensures that generated thumbnails are kept out of the version-
controlled DIR_TESTDATA directory.

Props bor0.
Fixes #40008.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#40008 closed defect (bug) (fixed)

A multisite test (currently unknown) should remove added image thumbnails

Description

Attachments (1)

Change History (6)

#1 @adamsilverstein 9 years ago

@bor0 9 years ago

#2 @bor0 9 years ago

#3 @netweb 9 years ago

#4 @boonebgorges 9 years ago

#5 @boonebgorges 9 years ago