WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 7 weeks ago

#40015 closed defect (bug) (fixed)

In multisite e-mails can contain HTML entities

Reported by: stephenharris Owned by: swissspidy
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Mail Keywords: has-patch has-unit-tests
Focuses: multisite Cc:

Description

This ticket concerns e-mails which are sent in a multsite context when a blog's admin e-mail is changed, or a user changes their e-mail address.

If the sitename contains HTML entities these appear in the e-mail - they are not decoded.

If the blogname contains quotes these appear in the e-mail as HTML entities. ([27801] decoded all but the quotes).

This bug was fixed for non-multsite installations in #9913. Also related: #35415 and #12584

Attachments (1)

40015.diff (9.0 KB) - added by stephenharris 4 months ago.
Decode HTML entities in site name and blog name for MS emails

Download all attachments as: .zip

Change History (7)

@stephenharris
4 months ago

Decode HTML entities in site name and blog name for MS emails

#1 @stephenharris
4 months ago

  • Keywords has-patch has-unit-tests added

Patch contains tests for bug. I've also included a couple of other tests relating to the two functions fixed, although not related to this ticket.

#2 @SergeyBiryukov
4 months ago

  • Focuses multisite added

#3 @swissspidy
3 months ago

  • Milestone changed from Awaiting Review to 4.8
  • Version trunk deleted

See also #39446, #35283.

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


7 weeks ago

#5 @swissspidy
7 weeks ago

  • Owner set to swissspidy
  • Status changed from new to reviewing

#6 @swissspidy
7 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 40632:

Mail: Ensure entities are decoded in email change notifications on Multisite.

Adds new tests to ensure this bug does not pop up again.

Props stephenharris.
Fixes #40015.

Note: See TracTickets for help on using tickets.