Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#40015 closed defect (bug) (fixed)

In multisite e-mails can contain HTML entities

Reported by: stephenharris's profile stephenharris Owned by: swissspidy's profile swissspidy
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Mail Keywords: has-patch has-unit-tests
Focuses: multisite Cc:


This ticket concerns e-mails which are sent in a multsite context when a blog's admin e-mail is changed, or a user changes their e-mail address.

If the sitename contains HTML entities these appear in the e-mail - they are not decoded.

If the blogname contains quotes these appear in the e-mail as HTML entities. ([27801] decoded all but the quotes).

This bug was fixed for non-multsite installations in #9913. Also related: #35415 and #12584

Attachments (1)

40015.diff (9.0 KB) - added by stephenharris 7 years ago.
Decode HTML entities in site name and blog name for MS emails

Download all attachments as: .zip

Change History (10)

7 years ago

Decode HTML entities in site name and blog name for MS emails

#1 @stephenharris
7 years ago

  • Keywords has-patch has-unit-tests added

Patch contains tests for bug. I've also included a couple of other tests relating to the two functions fixed, although not related to this ticket.

#2 @SergeyBiryukov
7 years ago

  • Focuses multisite added

#3 @swissspidy
7 years ago

  • Milestone changed from Awaiting Review to 4.8
  • Version trunk deleted

See also #39446, #35283.

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.

7 years ago

#5 @swissspidy
7 years ago

  • Owner set to swissspidy
  • Status changed from new to reviewing

#6 @swissspidy
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 40632:

Mail: Ensure entities are decoded in email change notifications on Multisite.

Adds new tests to ensure this bug does not pop up again.

Props stephenharris.
Fixes #40015.

#7 @johnbillion
7 years ago

In 41165:

Users: Re-add entity decoding to the site name before it's used in the email address change confirmation email.

This was accidentally removed in [41163].

See #40015, #16470

#8 @johnbillion
7 years ago

In 41170:

Users: Update some tests for admin email change confirmation emails after [41164].

See #40015, #39117

#9 @johnbillion
7 years ago

In 41171:

Users: Further fixes to entitiy decoding in the user email address change confirmation email, and the corresponding tests.

See #16470, #40015

Note: See TracTickets for help on using tickets.