WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 14 months ago

#40016 new defect (bug)

Twenty Seventeen: Nested comment replies don't indent properly

Reported by: DougJoseph Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.7.2
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Hello. On the Twenty Seventeen theme, in the comments area, nested replies don't indent properly.

The avatar indents, but the comment itself does not. This causes the comment to be partially covered up by the avatar.

I have confirmed the behavior occurring both on the default theme page with two columns, and on a full-width theme page with one column.

Below is a screenshot showing this issue in action:

http://wvupci.org/wp-content/uploads/Screen-Shot-2017-03-02-at-11.13.33-AM.png

Change History (5)

#1 @SergeyBiryukov
15 months ago

  • Component changed from General to Bundled Theme
  • Summary changed from Wordpress Twenty Seventeen - comments - nested replies don't indent properly to Twenty Seventeen: Nested comment replies don't indent properly

#2 follow-up: @sami.keijonen
15 months ago

Hi @DougJoseph, thanks for ticket!

I can't seem to reproduce this when I quickly tested. Can you test again with clean install and without any plugins?

#3 follow-up: @Dehumanizer
14 months ago

I also noticed this (on WP 4.7.3, just installed, no plugins except Jetpack (and temporarily disabling it didn't fix the problem). A reply to a reply is indented, but not the first reply to a top-level comment.

There may be better ways to do this, but I was able to fix it on my blog by changing this on style.css:

.comment-list,
.comment-list .children {
        list-style: none;
        margin: 0;
        padding: 0;
}

to:

.comment-list {
        list-style: none;
        margin: 0;
        padding: 0;
}

.comment-list .children {
        list-style: none;
        margin: 0;
        padding: 0;
        padding-left: 2em;
}

#4 in reply to: ↑ 3 @DougJoseph
14 months ago

Replying to Dehumanizer:

Thank you for the idea on how to approach getting a fix for this, Dehumanizer !

I was able to go into Dashboard > Appearance > Edit CSS --- and add the following, which worked for me. I had to add the last part because something was causing the avatar to be offset by only 45 pixels when 65 was what was needed.

ALSO, PLEASE NOTE: anyone trying to use this fix, who has any kind of CACHING plugin in force on your site, be aware I had to manually force a refresh of the cache before my changed were honored'''

/* Below: Fix for nested reply in comments not indenting properly */

.comment-list {
        list-style: none;
        margin: 0;
        padding: 0;
}

.comment-list .children {
        list-style: none;
        margin: 0;
        padding: 0;
        padding-left: 2em !important;
}

.children .comment-author .avatar {
	left: -65px !important;
}
Last edited 14 months ago by DougJoseph (previous) (diff)

#5 in reply to: ↑ 2 @DougJoseph
14 months ago

Replying to sami.keijonen:

Hi @DougJoseph, thanks for ticket!

I can't seem to reproduce this when I quickly tested. Can you test again with clean install and without any plugins?

Thanks for taking time to try to replicate. I confess my issue may be related to something other than a problem in the theme, however, I have too much on my plate right now to try to hunt that down. Just used some custom CSS edits to "force" things to work right. I notice one other person chimed in who has the issue on a fresh install, FWIW.

Note: See TracTickets for help on using tickets.