Shift-click to select a range of checkboxes isn't working anymore since 4.7.3 update

[ZehrGut]

Hello!
Shift-click to select a range of check-boxes in admin area isn't working anymore since 4.7.3 update. It worked perfectly before this 4.7.3 update.
Thanks in advance!

[swissspidy]

I can confirm this.

Related change in 4.7.3: #39739.

See also #39842.

[swissspidy]

Improved in [38703] but broken in [40118]

[afercia]

Yep, the change in [40118] was a bad suggestion by me, sorry for that. I think #39842 is unrelated though, can't reproduce.

[afercia]

So, before [38703] the original selector was:
$('tbody').children().children('.check-column').find(':checkbox').click( function(e) {

Because of #37973 this event needs to be delegated, and the selector was changed in [38703], then amended in [38706]:
$body.on( 'click', 'tbody .check-column :checkbox', function( event ) {

However, to support the edge case of nested tables (see #39739), it was changed again in [40118]:
$body.on( 'click', 'tbody > .check-column :checkbox', function( event ) {

The selector above doesn't actually select anything... instead it should be:
$body.on( 'click', 'tbody > tr > .check-column :checkbox', function( event ) {

which, starting from tbody, selects the children tr then the children .check-column and then all the :checkbox and should finally be equivalent to the original selector.

[afercia]

In 40268:

List Tables: After [38703], [38706], and [40118], adjust the jQuery selector to make the selection of a range of checkboxes work again.

Unprop afercia.
Fixes #40056.

[afercia]

Reopening for 4.7.4 consideration.

[swissspidy]

In 40327:

List Tables: After [38703], [38706], and [40118], adjust the jQuery selector to make the selection of a range of checkboxes work again.

Unprop afercia.
Fixes #40056.

Merges [40268] to the 4.7 branch.

[swissspidy]

#40092 was marked as a duplicate.

[femur]

It's still not working after upgrading to 4.7.4.

[afercia]

@femur thanks! Hm, seems this is working on trunk but not on 4.7.4, not sure the right commit was back-ported. @swissspidy any insight?

[dd32]

Incorrect changeset was indeed merged back, sorry folks, it'll be fixed in 4.7.5

[dd32]

In 40512:

List Tables: After [38703], [38706], and [40118], adjust the jQuery selector to make the selection of a range of checkboxes work again.

Unprop afercia.
Merges [40268] to the 4.7 branch.
Fixes #40056.

[dd32]

Just to note, [40327] was a merge of [40056] which thankfully was only tests which pass on 4.7 - I'm not going to remove them from the branch now that they're there, not doing any harm.

[swissspidy]

Ouch, sorry about that! Even though I usually double- and triple-check every commit and backport, I somehow mixed up ticket number and revision number.