WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #40070, comment 10


Ignore:
Timestamp:
05/22/2017 12:06:16 AM (2 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40070, comment 10

    initial v1  
    66I'm not sure you should convert it to a slug at all - slugification isn't designed to be used on arbitrary data like this, and causes this exact scenario.
    77
    8 I'd suggest it should return the JS-escaped folder name instead, and should be handled appropriately on the client side - that may mean that items need an extra attribute such as this: `class="plugin-{$slug_attempt_at_folder" data-folder="{$escaped_foldername}"` for filter/reference purposes.
     8I'd suggest it should return the JS-escaped folder name instead, and should be handled appropriately on the client side - that may mean that items need an extra attribute such as this: `class="plugin-{$slug_attempt_of_folder}" data-folder="{$escaped_foldername}"` for filter/reference purposes.