Ensure PHP 7.2 compatibility in tests (and core)

[ocean90]

The ​lastest Travis build for 7.2-dev has a few errors. I haven't found a roadmap but I think PHP 7.2 is planned for end of this year. So, while PHP 7.2 is still at the beginning we should start looking at the results and review each error. We did the same for PHP 7.1 and identified a bug in PHP itself, see #37295.

---

​PHP 7.2 is going to deprecate

• create_function()
• __autoload()
• each()
• calling assert() with a string argument

Also, ​counting of non-countable objects will start throwing a warning in PHP 7.2.

---

• create_function() is handled in #37082.
• The assert() calls in WP_Import_UnitTestCase::_import_wp() should be replaced with assertTrue() and a custom message.
• testXMLParser::parse(): sizeof() returns always 1 for a string, even if the string is empty. Same for false. Seems like we can just pass true as the third argument for xml_parse().

[desrosj]

Related #37082.

[desrosj]

Remove each() call.

[desrosj]

Added a patch to #37082 for all create_function() calls in unit tests.

Just added a patch here for removing each() calls. There are 16 other occurrences, but all within Snoopy and the Text_diff library.

I believe Snoopy is an abandoned project (hasn't been updated since 2014). Is this maintained in WordPress as a fork? I can update the patch if so.

Text_Diff also appears to not be maintained.

[netweb]

Replying to desrosj:

I believe Snoopy is an abandoned project (hasn't been updated since 2014). Is this maintained in WordPress as a fork? I can update the patch if so.

A quick look at the history of wp-includes/class-snoopy.php shows it's been continuing to receive compatibility updates where and when required these past few years since being deprecated ~7 years ago r14052

[desrosj]

Removes all each() calls, including those in Text_diff, Snoopy and in unit tests.

[desrosj]

Same as previous, but removed an extra stray {

[desrosj]

Fixes all assert() calls with strings passed.

[johnbillion]

Moving to 4.8 for visibility, in case we don't get 4.9 out before PHP 7.2.

[johnbillion]

In 40555:

Feeds: Remove an incorrect usage of sizeof() in a helper class used during unit testing of XML element handling.

This also helps tidy up the test output when running PHP 7.2.

See #40109

[ocean90]

In 40649:

Import: Replace assert() calls with PHPUnit's assertTrue() method.

Calling assert() with a string argument will be deprecated in PHP 7.2.

See #40109.

[swissspidy]

Regarding a roadmap for PHP 7.2 I only found this: ​https://wiki.php.net/todo/php72

[obenland]

@ocean90 Could you bring this over the finish line when you get a chance?

[ocean90]

Yep, but not for 4.8.

[pento]

WordPress 4.9 will be out before PHP 7.2, WordPress 5.0 may or may not be.

[swissspidy]

#41134 was marked as a duplicate.

[ayeshrajans]

Excerpt from #41134, I submitted a patch to remove move the legacy autoloader code to a new file and include it only if SPL is not available, and that fixed the deprecation notice in PHP 7.2, without removing the SPL polyfill.
I will attach that patch here as well.

[ayeshrajans]

Patch to move the spl_autoload polyfils and autoload declaration

[johnbillion]

FYI: PHP 7.2 alpha has been tagged and is now ​available on Travis as 7.2.

[ayeshrajans]

Also, PHP 7.2 is now branched off and has feature frozen (​https://externals.io/message/99903).

[johnbillion]

Opened #41457 for the incorrect use of count() in WP_REST_Comments_Controller::check_read_post_permission().

[johnbillion]

Avoid counting some uncountable items

[johnbillion]

In 41174:

General: Avoid counting uncountable values when reading theme directories, and in some unit tests.

See #40109

[jorbin]

In 41175:

Build/Test Tools: Add PHP 7.2 to test matrix

PHP has branched 7.2 and master is now 7.3. This change ensures that 7.2 is tested. As 7.2 is still in development and is not ready for production, failures are allowed.

See #40109.

[johnbillion]

In 41177:

Build/Test Tools: More PHP 7.2 tweaks for Travis CI.

See #40109

[johnbillion]

In 41178:

General: Move the __autoload() compat function into its own file to prevent deprecated notices being thrown by the compiler in PHP 7.2.

The __autoload() function is deprecated in PHP 7.2, which means WordPress' own __autoload() compat function for PHP 5.2 needs to be moved into a separate file to prevent the PHP 7.2 compiler from complaining.

Props ayeshrajans

See #40109

[johnbillion]

At least one of the fixes in 40109.4.patch​ for usage of each() is buggy because the array that's iterated over is altered during iteration. Needs a more comprehensive patch.

[johnbillion]

The each() issue is potentially complex, so I'm splitting each (heh) usage into its own ticket. First up: #41524

[johnbillion]

Two more:

• #41525
• #41526

Let's not bother trying to remove the usage of each() in the Snoopy class, because it's in a deprecated file.

[johnbillion]

In 41636:

Build/Test tools: Update the WP_PHPUnit_Util_Getopt class for PHP 7.2 compatibility.

This removes usage of each() which is deprecated in PHP 7.2.

Props ayeshrajans

See #40109
Fixes #41525

[johnbillion]

In 41637:

Build/Test tools: Update the WP_PHPUnit_Util_Getopt class for PHP 7.2 compatibility.

This removes usage of each() which is deprecated in PHP 7.2.

See #40109, #41525

Merges [41636] to the 4.8 branch.

[johnbillion]

In 41730:

I18N: Improvements to the tests for plural forms.

• Move the create_function() code into a file that's only loaded, and into a test that's only run, on PHP <= 7.2 to avoid deprecated warnings in 7.2+.
• Convert the test skipping into a failure if the GlotPress locale file cannot be downloaded.
• Ensure test_exceptions fails if an exception is not thrown.
• Docs improvements

See #41562, #40109

[johnbillion]

In 41748:

Build/Test tools: Remove PHP 7.2 from the allowed failures list on Travis CI.

Fixes #40109

[johnbillion]

Whoops, the #41524 sub-ticket still needs fixing.

[ayeshrajans]

The tests are passing (​https://travis-ci.org/WordPress/wordpress-develop/jobs/285002396)!

[westonruter]

In 42146:

Settings: Replace count() call with empty() in get_settings_errors() to prevent PHP 7.2 warnings when $wp_settings_errors is null.

Props pross, dd32, westonruter.
See #40109.
Fixes #42498 for trunk.

[westonruter]

In 42147:

Settings: Replace count() call with empty() in get_settings_errors() to prevent PHP 7.2 warnings when $wp_settings_errors is null.

Props pross, dd32, westonruter.
See #40109.
Fixes #42498 for 4.9.

[SergeyBiryukov]

In 43039:

Themes: Avoid a PHP 7.2 warning in get_theme_roots() when $wp_theme_directories is an uncountable value.

See [41174] for wp_get_themes() and get_raw_theme_root().

Props burlingtonbytes, teddytime, lbenicio, desrosj.
Fixes #43374. See #40109.

[SergeyBiryukov]

In 43040:

Themes: Avoid a PHP 7.2 warning in get_theme_roots() when $wp_theme_directories is an uncountable value.

See [41174] for wp_get_themes() and get_raw_theme_root().

Props burlingtonbytes, teddytime, lbenicio, desrosj.
Merges [43039] to the 4.9 branch.
Fixes #43374. See #40109.