WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 3 weeks ago

#40138 new enhancement

Bundled themes: the tag cloud widget should output a list

Reported by: afercia Owned by:
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: tag-cloud has-patch 2nd-opinion needs-testing
Focuses: ui, accessibility Cc:

Description

Splitting this out from #35566

Bundled themes should show best practices to theme authors. About the Tag Cloud widget, the latest patch on #35566 proposes some accessibility improvements, however it doesn't force the tags to be output as an unordered list to avoid the need to output some inline stylesheet.

A better option would be using the format argument to tweak the output on a case by case basis.

From a semantic perspective, the tags list is... well, a list. Setting the format argument to list would allow assistive technologies to announce the list as a list and the number of items in the list. Most of the users from the a11y testers group expressed a preference to have the number of items being announced, see the test results on #35566.

This would require some simple CSS adjustments, which is trivial to do in the Themes stylesheet.

Attachments (10)

40138.2015.diff (1.4 KB) - added by xkon 5 weeks ago.
TwentyFifteen ul fix for tag cloud
40138.2016.diff (1.2 KB) - added by xkon 5 weeks ago.
TwentyFifteen ul fix for tag cloud
40138.2014.diff (1.5 KB) - added by xkon 5 weeks ago.
Twenty Fourteen ul fix for tag cloud
40138.2013.diff (1.6 KB) - added by xkon 5 weeks ago.
Twenty Thirteen ul fix for tag cloud
40138.2012.diff (1.6 KB) - added by xkon 5 weeks ago.
Twenty Twelve ul fix for tag cloud
40138.2011.diff (1.4 KB) - added by xkon 5 weeks ago.
Twenty Eleven ul fix for tag cloud
40138.2011_1.diff (1.4 KB) - added by xkon 5 weeks ago.
Twenty Eleven ul fix for tag cloud - Updated function name.
40138.2010.diff (1.4 KB) - added by xkon 5 weeks ago.
Twenty Ten ul fix for tag cloud
40138_2010-2016.diff (10.2 KB) - added by xkon 5 weeks ago.
Bundle Patch for 2010 up to 2016 themes
40138.diff (10.2 KB) - added by xkon 4 weeks ago.
Standards Update.

Download all attachments as: .zip

Change History (28)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 months ago

#2 @afercia
5 months ago

See also ticket:35566#comment:32, it would be nice to have Twenty Seventeen filtering the Tag Cloud arguments instead of overriding the styles.

#3 @sami.keijonen
5 months ago

I'd say lets filter Tag Cloud arguments in the same way as in Twenty16. With small CSS tweaks we can make it look the same as now.

However this could break child themes styling for tag cloud. But I think it's more important to have more accessible tag cloud. Child themes can fix minor CSS.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 months ago

#5 @afercia
5 months ago

  • Keywords tag-cloud added
  • Milestone changed from Awaiting Review to 4.8

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 months ago

#7 @jbpaul17
3 months ago

  • Keywords needs-patch added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 months ago

#9 @afercia
3 months ago

  • Milestone changed from 4.8 to 4.8.1

This ticket was mentioned in Slack in #accessibility by adamsoucie. View the logs.


3 months ago

#11 @afercia
7 weeks ago

  • Milestone changed from 4.8.1 to 4.9

This ticket was mentioned in Slack in #core by xkon. View the logs.


5 weeks ago

@xkon
5 weeks ago

TwentyFifteen ul fix for tag cloud

#13 @xkon
5 weeks ago

Hello, I'll keep my diffs split up per theme to have easier access on them.

Also before everything to have a list of what is fixed

TwentySeventeen : @sami.keijonen in https://core.trac.wordpress.org/ticket/40184

Following the previous fix for TwentySeventeen to have similar code everywhere :

40138.2010.diff addresses the widget tagcloud fix for Twenty Ten.

40138.2011_1.diff addresses the widget tagcloud fix for Twenty Eleven.

40138.2012.diff addresses the widget tagcloud fix for Twenty Twelve.

40138.2013.diff addresses the widget tagcloud fix for Twenty Thirteen.

40138.2014.diff addresses the widget tagcloud fix for Twenty Fourteen.

40138.2015.diff addresses the widget tagcloud fix for Twenty Fifteen.

40138.2016.diff addresses the widget tagcloud fix for Twenty Sixteen ( sorry for the wrong name in the uploaded file, no idea how to edit that ).

I'll move on to the other themes uploading each patch with .YEAR respectively for each theme asap.

Best regards,
Konstantinos

Last edited 5 weeks ago by xkon (previous) (diff)

@xkon
5 weeks ago

TwentyFifteen ul fix for tag cloud

@xkon
5 weeks ago

Twenty Fourteen ul fix for tag cloud

@xkon
5 weeks ago

Twenty Thirteen ul fix for tag cloud

@xkon
5 weeks ago

Twenty Twelve ul fix for tag cloud

@xkon
5 weeks ago

Twenty Eleven ul fix for tag cloud

@xkon
5 weeks ago

Twenty Eleven ul fix for tag cloud - Updated function name.

@xkon
5 weeks ago

Twenty Ten ul fix for tag cloud

@xkon
5 weeks ago

Bundle Patch for 2010 up to 2016 themes

#14 @xkon
5 weeks ago

  • Keywords has-patch 2nd-opinion needs-testing added; needs-patch removed

Hello again,

I've uploaded a bundled patch with all the diffs for themes 2010 up to 2016 file: 40138_2010-2016.diff .

The other diffs are meant for single testing ( note: they might have differences from the final bundle, unfortunately I'm working remotely so it was difficult a bit to keep up everything in line with my pcs).

Hopefully this is close enough to address the matter at hand and proceed with the Admin Tag Cloud fixes as well.

Best regards,
Konstantinos

This ticket was mentioned in Slack in #core by xkon. View the logs.


5 weeks ago

@xkon
4 weeks ago

Standards Update.

#16 @xkon
4 weeks ago

I uploaded the final 40138.diff patch as I'm going through all of them to update to coding standards. My editor was a bit problematic 'on save' and I didn't realize till it was too late.

Sorry for the inconvenience if any was caused.

Best regards,
Konstantinos

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #accessibility by sergey. View the logs.


3 weeks ago

Note: See TracTickets for help on using tickets.