Context Navigation

← Previous Ticket
Next Ticket →

#40154 closed defect (bug) (fixed)

Incorrectly formatted $taxonomies parameter passed to wp_get_object_terms filter

Reported by:	ig_communitysites	Owned by:	boonebgorges
Priority:	normal	Milestone:	4.7.4
Component:	Taxonomy	Version:	4.7
Severity:	normal	Keywords:
Cc:		Focuses:

Description

According to documentation: the $taxonomies parameter passed into the wp_get_object_terms filter at line 1911 of wp-includes/taxonomy.php should be "SQL-formatted (comma-separated and quoted) list of taxonomy names". That definitely used to be the case on v4.5.

In 4.7.x, however, that $taxonomies parameter is formatted thus:

$taxonomies = implode( ',', $taxonomies );

on line 1895. That just produces a comma-separated list, without any quoting.

Change History (4)

#1 @boonebgorges
9 years ago

Milestone Awaiting Review → 4.7.4
Version 4.7.3 → 4.7

Hi @ig_communitysites - Thanks for the ticket, and welcome to WordPress Trac!

You are correct that this is a regression. It was introduced in [38667].

#2 @boonebgorges
9 years ago

Owner set to boonebgorges
Resolution → fixed
Status new → closed

In 40290:

Fix the formatting of $taxonomies parameter of 'wp_get_object_terms' filter.

[38667] changed the way that the filter parameters are built. That
changeset didn't fully account for the pre-4.7 format of $taxonomies.

Props ig_communitysites.
Fixes #40154.

#3 @boonebgorges
9 years ago

In 40291:

Fix the formatting of $taxonomies parameter of 'wp_get_object_terms' filter.

[38667] changed the way that the filter parameters are built. That
changeset didn't fully account for the pre-4.7 format of $taxonomies.

Merge of [40290] to the 4.7 branch.

Props ig_communitysites.
Fixes #40154.

#4 @sopha1982
10 months ago

Here, fix your problem. Click Here

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core