WordPress.org

Make WordPress Core

Opened 16 months ago

Last modified 10 months ago

#40158 reviewing defect (bug)

Plupload bug with Firefox and Mac OS where the user can't select .jpeg files

Reported by: stiofansisland Owned by: azaozz
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: External Libraries Keywords:
Focuses: javascript Cc:

Description

NOTE: Core currently uses Plupload version 2.1.8, this bug is solved in version 2.2.1 + (latest stable is 2.3.1).

The bug If plupload is limited to jpg/jpeg images and a user using FireFox and Mac OS tries to select images, all the .jpeg images are grayed out and not selectable, a user can select .jpg files but not .jpeg ones.

Bug Example (You need to be running FireFox on Mac OS to recreate) http://jsfiddle.net/sr8jarsc/1/

Solution Update the Plupload version to 2.2.1 or greater Example: http://jsfiddle.net/mr31zw6L/1/

Attachments (1)

40158.diff (283.9 KB) - added by bor0 15 months ago.

Download all attachments as: .zip

Change History (24)

#1 follow-up: @bor0
16 months ago

I (almost) have a patch ready, but can you please share the 2 images you're trying to upload so that I can test?

#2 in reply to: ↑ 1 @stiofansisland
15 months ago

Replying to bor0:

I (almost) have a patch ready, but can you please share the 2 images you're trying to upload so that I can test?

It seems to just go by extension so any .jpg and any .jpeg images will do.

Thanks,

Stiofan

@bor0
15 months ago

#3 @bor0
15 months ago

  • Keywords has-patch added

Was able to reproduce this. Added diff that updates the version of the library. Feel free to use https://gist.github.com/bor0/c1f47e46bf9824746ac06a5a4ac76b6f for testing. Note that this issue is only reproducible on Firefox.

#4 @swissspidy
15 months ago

  • Component changed from Upload to External Libraries
  • Milestone changed from Awaiting Review to 4.8
  • Version trunk deleted

#5 @swissspidy
15 months ago

#40207 was marked as a duplicate.

#6 @swissspidy
15 months ago

  • Milestone changed from 4.8 to 4.7.4

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


15 months ago

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


15 months ago

#9 @azaozz
15 months ago

  • Owner set to azaozz
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


15 months ago

#11 @swissspidy
15 months ago

  • Keywords needs-testing added

#12 @azaozz
15 months ago

  • Milestone changed from 4.7.4 to 4.7.5

Don't think we can merge this in time for 4.7.4-beta.

#13 @Otto42
14 months ago

#40207 was marked as a duplicate.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


14 months ago

#15 @desrosj
14 months ago

  • Milestone changed from 4.7.5 to 4.8

This ticket was mentioned in Slack in #core by obenland. View the logs.


13 months ago

#17 @obenland
13 months ago

  • Milestone changed from 4.8 to Future Release

#18 @wpcachepress
13 months ago

@obenland why so? this bug is related to other bug - chrome + non-standard TLDs too - media select bug https://core.trac.wordpress.org/ticket/40207

#19 @swissspidy
13 months ago

@wpcachepress The milestone was changed because WordPress 4.8 will probably be released today and this patch still needs testing.

#20 @azaozz
10 months ago

Unfortunately Plupload version 2.2.x and newer are released under the AGPLv3 license which is incompatible with GPLv2. We can update to the latest GPL Plupload, version 2.1.9. See #41755.

#21 @azaozz
10 months ago

  • Keywords has-patch needs-testing removed

#22 follow-up: @stiofansisland
10 months ago

In my testing 2.1.9 did not fix the issue... The plot thickens :(

#23 in reply to: ↑ 22 @azaozz
10 months ago

Replying to stiofansisland:

2.1.9 is the latest version we can bundle. From there on we will have to fix any bugs ourselves.

Note: See TracTickets for help on using tickets.