Menus that contain post types in Draft status should be hidden from logged out users

[jdingman]

I recently added 2 pages to my site. I published them, and moved them into a Menu on my site.

Then realized, I don't want them public, but I also don't want to lose their positioning where I put them in the menu. I moved them to draft.

When I go to my site logged out, I still see the links and goes to a 404.

I'm proposing that when an item in the Menu moves to a non-published state that isn't the Trash (Draft or Pending), it should remain in the nav, but be hidden from any logged out users.

[bor0]

I was able to reproduce this and I agree that it is a bug. Non-published pages do not appear on the dropdown list in Appearance > Menus. However, when once added to a menu, they will appear in the Menu Structure in wp-admin regardless of their publish status.

After proposed patch, unpublished items will appear as such "Name (Invalid)" on the wp-admin part.

[lukecavanagh]

WP Admin Menus

[lukecavanagh]

@bor0

Patch applies cleanly and works as expected.

[desrosj]

I think that it would be better not to declare draft content in the menu as "invalid".

I added a new patch that shows draft items as orange with a new warning. They are then filtered out the same way as invalid items, but with a new filter function checking that the content is published.

Customizer support for this approach needs to be added.

[desrosj]

Replaces space indentation with tabs. Still configuring new editor.