Changes between Version 1 and Version 2 of Ticket #40180, comment 1
- Timestamp:
- 03/17/2017 01:53:15 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #40180, comment 1
v1 v2 1 1 I'm liking the `get_site_by()` idea, from a processing standpoint. 2 2 3 I'm still not super fond of the idea of deprecating `get_blog_details()`, primarily because of the amount of person-hours that 3rd-parties will end up spending on moving to the new function, and users upgrading plugins/etc because of it (EG: I have 559 instances of the use of `get_blog_details()` outside of Core in the codebase I work on). But at least having a direct replacement means devs have more options (regex replace s, etc).3 I'm still not super fond of the idea of deprecating `get_blog_details()`, primarily because of the amount of person-hours that 3rd-parties will end up spending on moving to the new function, and users upgrading plugins/etc because of it (EG: I have 559 instances of the use of `get_blog_details()` outside of Core in the codebase I work on). But at least having a direct replacement means devs have more options (regex replacements, etc). 4 4 5 5 Keeping the full functionality around is ultimately what matters, so it's still a more viable option than the previous plan.