WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#40198 closed defect (bug) (fixed)

Customize: all previewable links are blocked in the customize preview on IE11

Reported by: celloexpressions Owned by: westonruter
Milestone: 4.7.4 Priority: low
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch has-screenshots commit fixed-major
Focuses: Cc:

Description

Edge is fine, but on IE11 all previewable links are identified as blocked with cursor: not-allowed and the links not being navigable. Probably only worth fixing if it's an easy fix - IE is generally on the way out in favor of Edge.

Attachments (1)

40198.0.diff (1.3 KB) - added by westonruter 3 months ago.

Download all attachments as: .zip

Change History (16)

#1 @celloexpressions
3 months ago

  • Type changed from defect (bug) to enhancement

#2 @westonruter
3 months ago

  • Milestone changed from Awaiting Review to 4.7.4
  • Owner set to westonruter
  • Status changed from new to accepted
  • Type changed from enhancement to defect (bug)

Seems like a definite bug that should be fixed. Downloading an IE11 VM now.

@westonruter
3 months ago

#3 @westonruter
3 months ago

  • Keywords has-patch added; needs-patch removed

Looks like it's a remaining issue from #38409, where IE11 is adding the port number unexpectedly. 40198.0.diff strips off the default port of :80 which should resolve this issue. It fixes it for me in my tests on an IE11 VM.

@celloexpressions can you confirm?

#4 @westonruter
3 months ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


3 months ago

#7 @afercia
3 months ago

  • Keywords has-screenshots commit added; needs-testing removed

Screenshot of the reproduced issue on Windows 10 - IE 11:

https://cldup.com/-Csuv1lJsX.png

Tested 40198.0.diff on a native Win 10 - IE 11 and links in the preview work perfectly.

#8 @westonruter
3 months ago

This issue was reported to Microsoft as well:

[IE11 & scripting] Value of HTMLAnchorElement.host differs between script-created link and link from document

https://connect.microsoft.com/ie/feedback/details/817343/ie11-scripting-value-of-htmlanchorelement-host-differs-between-script-created-link-and-link-from-document

#9 @westonruter
3 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 40318:

Customize: Fix navigation of site in preview on IE11.

Addresses issue in IE11 where the default port number of :80 is unexpectedly included on link.host for links dynamically created by scripts.

Props westonruter, afercia for testing.
See #38409.
Fixes #40198.

#10 @westonruter
3 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for consideration in 4.7.4

#11 @swissspidy
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40335:

Customize: Fix navigation of site in preview on IE11.

Addresses issue in IE11 where the default port number of :80 is unexpectedly included on link.host for links dynamically created by scripts.

Props westonruter, afercia for testing.
See #38409.
Fixes #40198.

Merges [40318] to the 4.7 branch.

#12 @westonruter
3 months ago

  • Keywords fixed-major removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Per @mattwiebe in #38409:

Found another "fun" bug related to this in IE11 for https sites: the :443 port also gets spuriously added, causing the postMessage bridge to fail.

Patch incoming, can move this to a new issue if needed, but this is where the work for port 80 was already done.

See https://core.trac.wordpress.org/attachment/ticket/38409/38409.3.diff

#13 @westonruter
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40381:

Customize: Fix HTTPS navigation of site in preview on IE11.

Accounts for HTTPS links (port 443) where [40318] only accounted for HTTP links (port 80). Addresses issue in IE11 where the default port number is unexpectedly included on link.host for links dynamically created by scripts.

Props mattwiebe.
Amends [40318], [38890].
See #38409.
Fixes #40198.

#14 @westonruter
3 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening (again) for merging into 4.7.4

#15 @swissspidy
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40386:

Customize: Fix HTTPS navigation of site in preview on IE11.

Accounts for HTTPS links (port 443) where [40318] only accounted for HTTP links (port 80). Addresses issue in IE11 where the default port number is unexpectedly included on link.host for links dynamically created by scripts.

Props mattwiebe.
Amends [40318], [38890].
See #38409.
Fixes #40198.

Merges [40381] to the 4.7 branch.

Note: See TracTickets for help on using tickets.