Twenty Seventeen: navigation.js should be enqueued with jQuery as dependency

[chesio]

Hi,

I run into an "jQuery is not defined" issue with Twenty Seventeen when I try to re-queue jQuery into footer, because /assets/js/navigation.js is enqueued without jQuery as dependency.

Fix is simple, I've attached a patch.

Cheers,
Česlav

[peterwilsoncc]

@chesio,

Thanks for providing the patch.

Although the patch works, it doesn't meet the ​WordPress PHP coding standards which require spaces inside the brackets, ie array( 'jquery' ). The coding standards are in place to make reading the code easier for future developers.

I've marked the patch as needing a refresh and to be fixed in the next release.

[chesio]

Hi @peterwilsoncc,

Thanks for pointing that out: refreshed patch attached.

[SergeyBiryukov]

In 40315:

Twenty Seventeen: Declare jQuery as a dependency for navigation.js.

Props chesio.
Fixes #40224.

[swissspidy]

In 40373:

Twenty Seventeen: Declare jQuery as a dependency for navigation.js.

Props chesio.
Fixes #40224.

Merges [40315] to the 4.7 branch.