Opened 8 years ago
Closed 8 years ago
#40224 closed defect (bug) (fixed)
Twenty Seventeen: navigation.js should be enqueued with jQuery as dependency
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.7.4 | Priority: | normal |
| Severity: | normal | Version: | 4.7 |
| Component: | Bundled Theme | Keywords: | has-patch fixed-major |
| Focuses: | Cc: |
Description
Hi,
I run into an "jQuery is not defined" issue with Twenty Seventeen when I try to re-queue jQuery into footer, because /assets/js/navigation.js is enqueued without jQuery as dependency.
Fix is simple, I've attached a patch.
Cheers,
Česlav
Attachments (2)
Change History (8)
#1
@
8 years ago
- Keywords has-patch needs-refresh added
- Milestone changed from Awaiting Review to 4.7.4
- Version changed from trunk to 4.7
#2
@
8 years ago
- Keywords needs-refresh removed
Hi @peterwilsoncc,
Thanks for pointing that out: refreshed patch attached.
This ticket was mentioned in Slack in #core by swissspidy. View the logs.
8 years ago
#4
@
8 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 40315:
Note: See
TracTickets for help on using
tickets.
@chesio,
Thanks for providing the patch.
Although the patch works, it doesn't meet the WordPress PHP coding standards which require spaces inside the brackets, ie
array( 'jquery' ). The coding standards are in place to make reading the code easier for future developers.I've marked the patch as needing a refresh and to be fixed in the next release.