WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#40260 new enhancement

Consider to remove some left overs from the old jQuery.suggest

Reported by: afercia Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.7
Component: Administration Keywords: deprecated-css has-patch
Focuses: Cc:

Description

Noticed while investigating on #40242. Core doesn't use jquery.suggest since [38797], however there are some left overs here and there that reference the ac_results class used for the jquery.suggest results.

The JavaScript part can be safely removed. The CSS part might still be used by some very old plugins so maybe better to keep it and add some inline comment.

See quick discussion on Slack:
https://wordpress.slack.com/archives/C02QB2JS7/p1490370129805243

Aside: Maybe one more reason to add a deprecated.css somewhere, as this idea has been around since a while. See for example #21456, #26396, and also https://make.wordpress.org/core/2014/12/19/core-css-roadmap/

Attachments (2)

40260.diff (1.1 KB) - added by afercia 3 years ago.
40260.1.diff (1.0 KB) - added by Hareesh Pillai 6 months ago.
Patch refreshed

Download all attachments as: .zip

Change History (4)

#1 @afercia
3 years ago

See also #27555 where the decision was to keep the CSS in core for backwards compatibility.

@afercia
3 years ago

#2 @afercia
3 years ago

  • Keywords has-patch added

@Hareesh Pillai
6 months ago

Patch refreshed

Note: See TracTickets for help on using tickets.