Opened 7 years ago
Closed 4 years ago
#40260 closed enhancement (fixed)
Consider to remove some left overs from the old jQuery.suggest
Reported by: | afercia | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Administration | Keywords: | deprecated-css has-patch needs-testing |
Focuses: | Cc: |
Description
Noticed while investigating on #40242. Core doesn't use jquery.suggest
since [38797], however there are some left overs here and there that reference the ac_results
class used for the jquery.suggest
results.
The JavaScript part can be safely removed. The CSS part might still be used by some very old plugins so maybe better to keep it and add some inline comment.
See quick discussion on Slack:
https://wordpress.slack.com/archives/C02QB2JS7/p1490370129805243
Aside: Maybe one more reason to add a deprecated.css
somewhere, as this idea has been around since a while. See for example #21456, #26396, and also https://make.wordpress.org/core/2014/12/19/core-css-roadmap/
Attachments (4)
Change History (11)
This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.
4 years ago
#4
@
4 years ago
- Milestone changed from Awaiting Review to 5.6
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
@
4 years ago
Clear up comment verbiage. New verbiage "Back-compat styles from deprecated jQuery.suggest, see ticket #40260."
#5
@
4 years ago
Quick refresh in 40260.3.diff to correct the comment language.
P.S. I'm all for a deprecated.css, I feel that's a great idea and for those wanting clean installs that know they don't use any of that css hopefully they can easily dequeue it.
See also #27555 where the decision was to keep the CSS in core for backwards compatibility.