Incorrect error assertions in some REST API tests
|Reported by:||dlh||Owned by:||jnylen0|
Description (last modified by dlh)
The test_delete_item() and test_delete_item_skip_trash() methods in WP_Test_REST_Posts_Controller contain the assertion $this->assertNotInstanceOf( 'WP_Error', $response );.
If I'm reading correctly, these assertions will always pass because they check a WP_REST_Response object. Instead, the assertions should check $response->as_error(), as happens in WP_Test_REST_Users_Controller.
The attached patch updates these assertions, as well as some similar assertions in WP_Test_REST_Post_Type_Controller_Testcase.
In the post type assertions, it looks as though the $response can be a WP_REST_Response, so it passes assertNotInstanceOf( 'WP_Error' ) but is still capable of returning a WP_Error via as_error().
The rest of the assertions in those post type methods might make the as_error() check unnecessary, though.
Change History (7)
- Owner set to jnylen0
- Resolution set to fixed
- Status changed from new to closed